chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java - Issue 2751333006: Create the base Custom Context Menu Dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

Issue 2751333006: Create the base Custom Context Menu Dialog. (Closed)

Patch Set: Fixed based off tedchoc's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuItem.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuUi.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

index cfbaa87973dbca75852187beb8505ce7cd87f3cb..80c8b1b0c6fd96ed2d04e27ddef266f0e1f0394b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/PlatformContextMenuUi.java

@@ -28,9 +28,8 @@ public class PlatformContextMenuUi implements ContextMenuUi {

@Override

public void displayMenu(Activity activity, ContextMenuParams params,

- List<Pair<Integer, List<ContextMenuItem>>> itemGroups,

- final Callback<Integer> listener) {

+ List<Pair<Integer, List<ContextMenuItem>>> itemGroups, final Callback<Integer> listener,

+ Runnable onMenuShown, Runnable onMenuClosed) {

String headerText = ChromeContextMenuPopulator.createHeaderText(params);

if (TextUtils.isEmpty(headerText)) {

setHeaderText(activity, mMenu, headerText);