Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/android/java/res/layout/tabular_context_menu_row.xml

Issue 2751333006: Create the base Custom Context Menu Dialog. (Closed)
Patch Set: Fixed based off tedchoc's comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/tabular_context_menu_row.xml
diff --git a/chrome/android/java/res/layout/tabular_context_menu_row.xml b/chrome/android/java/res/layout/tabular_context_menu_row.xml
new file mode 100644
index 0000000000000000000000000000000000000000..51a8498e07e3694a45e50ec8f3af3488df16b97a
--- /dev/null
+++ b/chrome/android/java/res/layout/tabular_context_menu_row.xml
@@ -0,0 +1,34 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- Copyright 2017 The Chromium Authors. All rights reserved.
+ Use of this source code is governed by a BSD-style license that can be
+ found in the LICENSE file. -->
+<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+ android:orientation="horizontal"
+ android:layout_width="match_parent"
+ android:layout_height="wrap_content"
+ android:paddingStart="15dp"
+ android:paddingEnd="15dp"
+ android:minHeight="40dp">
+ <ImageView
+ android:id="@+id/context_menu_icon"
+ android:layout_width="20dp"
+ android:layout_height="20dp"
+ android:layout_gravity="center_vertical"
+ android:contentDescription="@string/context_menu_row_icon_description" />
Ted C 2017/03/28 17:31:43 I think this should be @null here
JJ 2017/03/28 21:16:12 Done.
+ <TextView
+ android:id="@+id/context_text"
+ android:layout_width="0dp"
+ android:layout_height="wrap_content"
+ android:layout_gravity="center_vertical"
+ android:layout_marginStart="10dp"
+ android:layout_weight="1"
+ android:textSize="15sp"
+ android:textColor="#dd000000"/>
+ <ImageView
Ted C 2017/03/28 17:31:44 should we remove this for now?
JJ 2017/03/28 21:16:12 Done.
+ android:id="@+id/context_menu_share_icon"
+ android:layout_width="20dp"
+ android:layout_height="20dp"
+ android:layout_gravity="center_vertical"
+ android:contentDescription="@null"
+ android:visibility="gone"/>
+</LinearLayout>

Powered by Google App Engine
This is Rietveld 408576698