chrome/android/java/res/layout/custom_context_menu_row.xml - Issue 2751333006: Create the base Custom Context Menu Dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/custom_context_menu_row.xml

Issue 2751333006: Create the base Custom Context Menu Dialog. (Closed)

Patch Set: Updated tests and header Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/res/layout/custom_context_menu.xml ('K') | « chrome/android/java/res/layout/custom_context_menu.xml ('k') | chrome/android/java/res/layout/multi_type_context_menu.xml » ('j') | chrome/android/java/res/layout/multi_type_context_menu.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>
	Ted C 2017/03/24 04:32:53 tabular_context_menu_row tabular_context_menu_row JJ 2017/03/25 01:40:25 Done. Show quoted text On 2017/03/24 04:32:53, Ted C wrote: > tabular_context_menu_row Done.
	2 <!-- Copyright 2017 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"

	6 android:orientation="horizontal"

	7 android:layout_width="match_parent"

	8 android:layout_height="wrap_content"

	9 android:paddingStart="15dp"

	10 android:paddingEnd="15dp"

	11 android:minHeight="40dp">

	12 <ImageView

	13 android:id="@+id/context_menu_icon"

	14 android:layout_width="20dp"

	15 android:layout_height="20dp"

	16 android:layout_gravity="center_vertical"

	17 android:contentDescription="@string/context_menu_row_icon_description" / >
	Ted C 2017/03/24 04:32:53 I wouldn't set a content description here (applies I wouldn't set a content description here (applies to later in the code), or more explicitly use @null. In accessibility, the text is all the user needs to know to make a decision in the menu. This would just duplicate the text and isn't any more actionable. JJ 2017/03/25 01:40:25 Done. Show quoted text On 2017/03/24 04:32:53, Ted C wrote: > I wouldn't set a content description here (applies to later in the code), or > more explicitly use @null. In accessibility, the text is all the user needs to > know to make a decision in the menu. This would just duplicate the text and > isn't any more actionable. Done.
	18 <TextView

	19 android:id="@+id/context_text"

	20 android:layout_width="0dp"

	21 android:layout_height="wrap_content"

	22 android:layout_gravity="center_vertical"

	23 android:layout_marginStart="10dp"

	24 android:layout_weight="1"

	25 android:textSize="15sp"

	26 android:textColor="#dd000000"/>

	27 <ImageView

	28 android:id="@+id/context_menu_share_icon"

	29 android:layout_width="20dp"

	30 android:layout_height="20dp"

	31 android:layout_gravity="center_vertical"

	32 android:contentDescription="@string/context_menu_row_share_icon_descript ion"

	33 android:visibility="gone"/>

	34 </LinearLayout>

OLD	NEW