chrome/android/java/res/drawable/custom_context_menu_checkerboard_image_background.xml - Issue 2751333006: Create the base Custom Context Menu Dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/drawable/custom_context_menu_checkerboard_image_background.xml

Issue 2751333006: Create the base Custom Context Menu Dialog. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/context_menu_share.png ('k') | chrome/android/java/res/drawable/custom_context_menu_image_border.xml » ('j') | chrome/android/java/res/layout/custom_context_menu_row.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <bitmap xmlns:android="http://schemas.android.com/apk/res/android"
	David Trainor- moved to gerrit 2017/03/21 16:30:02 Do we want the copyright here too? Do we want the copyright here too? JJ 2017/03/22 23:35:31 Oh I'm surprised it didn't yell at me for this. Show quoted text On 2017/03/21 16:30:02, David Trainor-ping if over 24h wrote: > Do we want the copyright here too? Oh I'm surprised it didn't yell at me for this.
	3 android:src="@drawable/context_menu_checkerboard"
	David Trainor- moved to gerrit 2017/03/21 16:30:02 Just curious, do we use a checkerboard for anythin Just curious, do we use a checkerboard for anything else on Android (aside from rendering)? We should be able to do this without an actual bitmap. Can we just define a custom drawable that does the checkerboard? JJ 2017/03/22 23:35:31 Oooooo! This is interesting. So there is a way to Show quoted text On 2017/03/21 16:30:02, David Trainor-ping if over 24h wrote: > Just curious, do we use a checkerboard for anything else on Android (aside from > rendering)? > > We should be able to do this without an actual bitmap. Can we just define a > custom drawable that does the checkerboard? Oooooo! This is interesting. So there is a way to do it but it's complicated. We create a layerlist for the 4 squares. Convert this to a bitmap, then to a bitmap drawable then have that bitmap drawable repeat constantly. So it's more of a question of a tradeoff question more than anything. However! I've done it and I want to get your opinion on it. Take a look at CustomContextMenuDialog.
	4 android:tileMode="repeat"/>

OLD	NEW