Source/core/dom/ElementRareData.h - Issue 27513004: Make ElementRareData::ensureShadow() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ElementRareData.h

Issue 27513004: Make ElementRareData::ensureShadow() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/ElementRareData.h

diff --git a/Source/core/dom/ElementRareData.h b/Source/core/dom/ElementRareData.h

index 956eda783b4e507214e46bbdbead22154cef6b81..574d3e4cc8b7ad0bf5180f76605520611273e63a 100644

--- a/Source/core/dom/ElementRareData.h

+++ b/Source/core/dom/ElementRareData.h

@@ -98,11 +98,11 @@ public:

void clearShadow() { m_shadow = nullptr; }

ElementShadow* shadow() const { return m_shadow.get(); }

- ElementShadow* ensureShadow()

+ ElementShadow& ensureShadow()

{

if (!m_shadow)

m_shadow = ElementShadow::create();

- return m_shadow.get();

+ return *m_shadow.get();

adamk 2013/10/16 15:17:21 Nit: you can remove the .get()

Inactive 2013/10/16 15:20:17 Done.

}

NamedNodeMap* attributeMap() const { return m_attributeMap.get(); }

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »