Issue 27513004: Make ElementRareData::ensureShadow() return a reference

Issue 27513004: Make ElementRareData::ensureShadow() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
tkent, adamk

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Make ElementRareData::ensureShadow() return a reference Make ElementRareData::ensureShadow() return a reference as it can never return null. This makes the calling code look safer. R=tkent BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159819

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
M	Source/core/dom/Element.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/Element.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/ElementRareData.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm with a nit https://codereview.chromium.org/27513004/diff/1/Source/core/dom/ElementRareData.h File Source/core/dom/ElementRareData.h (right): https://codereview.chromium.org/27513004/diff/1/Source/core/dom/ElementRareData.h#newcode105 Source/core/dom/ElementRareData.h:105: return *m_shadow.get(); Nit: you can ...

7 years, 2 months ago (2013-10-16 15:17:21 UTC) #2

Inactive

https://codereview.chromium.org/27513004/diff/1/Source/core/dom/ElementRareData.h File Source/core/dom/ElementRareData.h (right): https://codereview.chromium.org/27513004/diff/1/Source/core/dom/ElementRareData.h#newcode105 Source/core/dom/ElementRareData.h:105: return *m_shadow.get(); On 2013/10/16 15:17:21, adamk wrote: > Nit: ...

7 years, 2 months ago (2013-10-16 15:20:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27513004/7001

7 years, 2 months ago (2013-10-16 15:20:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27513004/7001

7 years, 2 months ago (2013-10-16 20:42:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27513004/7001

7 years, 2 months ago (2013-10-17 01:36:57 UTC) #6

Message was sent while issue was closed.

Change committed as 159819

Expand Messages | Collapse Messages