Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: third_party/sqlite/src/test/shell3.test

Issue 2751253002: [sql] Import SQLite 3.17.0. (Closed)
Patch Set: also clang on Linux i386 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/sqlite/src/test/shell2.test ('k') | third_party/sqlite/src/test/shell4.test » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/src/test/shell3.test
diff --git a/third_party/sqlite/src/test/shell3.test b/third_party/sqlite/src/test/shell3.test
index ce1fd4ecb5d82931fc0dddf5abaa1f2b63a71885..bb2524c1ccebe50854f0e54006c19a5321049f93 100644
--- a/third_party/sqlite/src/test/shell3.test
+++ b/third_party/sqlite/src/test/shell3.test
@@ -21,19 +21,23 @@
#
set testdir [file dirname $argv0]
source $testdir/tester.tcl
-if {$tcl_platform(platform)=="windows"} {
- set CLI "sqlite3.exe"
-} else {
- set CLI "./sqlite3"
-}
-if {![file executable $CLI]} {
- finish_test
- return
-}
+set CLI [test_find_cli]
db close
forcedelete test.db test.db-journal test.db-wal
sqlite3 db test.db
+# There are inconsistencies in command-line argument quoting on Windows.
+# In particular, individual applications are responsible for command-line
+# parsing in Windows, not the shell. Depending on whether the sqlite3.exe
+# program is compiled with MinGW or MSVC, the command-line parsing is
+# different. This causes problems for the tests below. To avoid
+# issues, these tests are disabled for windows.
+#
+if {$::tcl_platform(platform)=="windows"} {
+ finish_test
+ return
+}
+
#----------------------------------------------------------------------------
# shell3-1.*: Basic tests for running SQL statments from command line.
#
@@ -92,6 +96,6 @@ do_test shell3-2.6 {
} {0 {}}
do_test shell3-2.7 {
catchcmd "foo.db" "CREATE TABLE"
-} {1 {Error: incomplete SQL: CREATE TABLE}}
+} {1 {Error: near line 1: near "TABLE": syntax error}}
finish_test
« no previous file with comments | « third_party/sqlite/src/test/shell2.test ('k') | third_party/sqlite/src/test/shell4.test » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698