Issue 27512003: Enable calling the SetReference* & SetObjectGroupId functions with a Persistent<SubclassOfValue>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27512003: Enable calling the SetReference* & SetObjectGroupId functions with a Persistent<SubclassOfValue>. (Closed)

Created:
7 years, 2 months ago by marja

Modified:
7 years, 2 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr., kouhei (in TOK)

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Enable calling the SetReference* & SetObjectGroupId functions with a Persistent<SubclassOfValue>. This is needed for https://codereview.chromium.org/26792002/ BUG= R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17253

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+144 lines, -19 lines)			Patch
M	include/v8.h	View	6 chunks	+38 lines, -7 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+11 lines, -10 lines	0 comments	Download
M	test/cctest/test-api.cc	View	3 chunks	+95 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. Not especially a candidate for a coding/API beauty contest, but well... :-}

7 years, 2 months ago (2013-10-17 09:59:33 UTC) #2

marja

7 years, 2 months ago (2013-10-17 11:48:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17253 (presubmit successful).