Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/devtools/front_end/main/Main.js

Issue 2751173003: [DevTools] Turn ConsoleModel into a singleton (Closed)
Patch Set: rebased Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/main/Main.js
diff --git a/third_party/WebKit/Source/devtools/front_end/main/Main.js b/third_party/WebKit/Source/devtools/front_end/main/Main.js
index 47b3de84e8cc26e066df621e566daa283ef8778c..bfa374855a2bb02f5e3733b4ac3f00b0f8b0737a 100644
--- a/third_party/WebKit/Source/devtools/front_end/main/Main.js
+++ b/third_party/WebKit/Source/devtools/front_end/main/Main.js
@@ -165,7 +165,7 @@ Main.Main = class {
UI.ContextMenu.installHandler(document);
UI.Tooltip.installHandler(document);
Components.dockController = new Components.DockController(canDock);
- SDK.multitargetConsoleModel = new SDK.MultitargetConsoleModel();
+ SDK.consoleModel = new SDK.ConsoleModel();
SDK.multitargetNetworkManager = new SDK.MultitargetNetworkManager();
SDK.targetManager.addEventListener(
SDK.TargetManager.Events.SuspendStateChanged, this._onSuspendStateChanged.bind(this));
@@ -602,9 +602,9 @@ Main.Main.WarningErrorCounter = class {
this._warnings = this._createItem(shadowRoot, 'smallicon-warning');
this._titles = [];
- SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._update, this);
- SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._update, this);
- SDK.multitargetConsoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, this._update, this);
+ SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.ConsoleCleared, this._update, this);
+ SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageAdded, this._update, this);
+ SDK.consoleModel.addEventListener(SDK.ConsoleModel.Events.MessageUpdated, this._update, this);
this._update();
}
@@ -637,8 +637,8 @@ Main.Main.WarningErrorCounter = class {
}
_update() {
- var errors = SDK.multitargetConsoleModel.errors();
- var warnings = SDK.multitargetConsoleModel.warnings();
+ var errors = SDK.consoleModel.errors();
+ var warnings = SDK.consoleModel.warnings();
this._titles = [];
this._toolbarItem.setVisible(!!(errors || warnings));

Powered by Google App Engine
This is Rietveld 408576698