Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 275113002: [Android] Avoid early fling termination if initial time is non-positive (Closed)

Created:
6 years, 7 months ago by jdduke (slow)
Modified:
6 years, 7 months ago
Reviewers:
bokan
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Android] Avoid early fling termination if initial time is non-positive Main thread animations provide no guarantees that the initial fling timestamp will be strictly positive. Consequently, a (valid) timestamp of 0 applied to Android's fling animation curve will yield a zero-sized scroll delta. Feeding this scroll delta through WebViewImpl reports that scrolling is impossible, in which case the fling will early terminate. Avoid this case by early returning on non-positive fling timestamps, aligning with Aura's fling behavior. BUG=371854 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269594

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/child/fling_animator_impl_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jdduke (slow)
bokan@: PTAL. At some point I'd like to add a few smoke tests for FlingAnimatorImplAndroid ...
6 years, 7 months ago (2014-05-09 15:43:48 UTC) #1
bokan
On 2014/05/09 15:43:48, jdduke wrote: > bokan@: PTAL. At some point I'd like to add ...
6 years, 7 months ago (2014-05-09 15:50:22 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 7 months ago (2014-05-09 15:51:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/275113002/1
6 years, 7 months ago (2014-05-09 15:53:38 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 18:24:22 UTC) #5
Message was sent while issue was closed.
Change committed as 269594

Powered by Google App Engine
This is Rietveld 408576698