third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/extendable-message-event.html - Issue 2751113005: Upstream service worker message event tests to WPT

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/extendable-message-event.html

Issue 2751113005: Upstream service worker message event tests to WPT (Closed)

Patch Set: Incorporate review feedback Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/ServiceWorkerGlobalScope/resources/extendable-message-event-utils.js ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/resources/extendable-message-event-worker.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
	(Empty)
1 <!DOCTYPE html>

2 <title>ServiceWorkerGlobalScope: ExtendableMessageEvent</title>

3 <script src='../../resources/testharness.js'></script>

4 <script src='../../resources/testharnessreport.js'></script>

5 <script src='../resources/test-helpers.js'></script>

6 <script>

7

8 // This test should be in chromium/ because the spec does not define behavior in

9 // the case where postMessage() is called from a detached client.
falken 2017/03/21 14:42:56 I'm wondering why this file can be deleted given t I'm wondering why this file can be deleted given the comment. Is there a WPT now testing this behavior? mike3 2017/03/21 17:15:29 It most certainly can not be deleted. This was m Show quoted text On 2017/03/21 14:42:56, falken wrote: > I'm wondering why this file can be deleted given the comment. Is there a WPT now > testing this behavior? It most certainly can not be deleted. This was my mistake; I was over-zelous in removing the test I introduced in the previous version of this patch. This test remains valid, but only for Chromium, so I've re-added it as originally authored.
10 promise_test(function(t) {

11 var script = 'resources/empty-worker.js';

12 var scope = 'resources/scope/extendable-message-event-from-detached';

13

14 return service_worker_unregister_and_register(t, script, scope)

15 .then(function(registration) {

16 add_completion_callback(function() { registration.unregister(); });

17 return wait_for_state(t, registration.installing, 'activated');

18 })

19 .then(function() { return with_iframe(scope); })

20 .then(function(frame) {

21 var worker = frame.contentWindow.navigator.serviceWorker.controller;

22 frame.remove();

23 assert_throws(

24 { name: 'InvalidStateError' },

25 function() { worker.postMessage(''); },

26 'postMessage on a detached client should throw an exception.');

27 });

28 }, 'Post an extendable message from a detached client');

29

30 </script>

OLD	NEW