Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8552)

Unified Diff: chrome/common/chrome_content_client.cc

Issue 2751103008: gpu: Add a util method to set crash-keys from a GPUInfo. (Closed)
Patch Set: comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_content_client.cc
diff --git a/chrome/common/chrome_content_client.cc b/chrome/common/chrome_content_client.cc
index 099b93a759c632885e6ab9a824ec9b36aecf2c8c..02b38d7009ed7c89e2171f93d285bdcd60fdf7f8 100644
--- a/chrome/common/chrome_content_client.cc
+++ b/chrome/common/chrome_content_client.cc
@@ -43,6 +43,7 @@
#include "extensions/common/constants.h"
#include "extensions/features/features.h"
#include "gpu/config/gpu_info.h"
+#include "gpu/config/gpu_util.h"
#include "media/media_features.h"
#include "net/http/http_util.h"
#include "pdf/features.h"
@@ -449,24 +450,7 @@ void ChromeContentClient::SetActiveURL(const GURL& url) {
}
void ChromeContentClient::SetGpuInfo(const gpu::GPUInfo& gpu_info) {
-#if !defined(OS_ANDROID)
- base::debug::SetCrashKeyValue(crash_keys::kGPUVendorID,
- base::StringPrintf("0x%04x", gpu_info.gpu.vendor_id));
- base::debug::SetCrashKeyValue(crash_keys::kGPUDeviceID,
- base::StringPrintf("0x%04x", gpu_info.gpu.device_id));
-#endif
- base::debug::SetCrashKeyValue(crash_keys::kGPUDriverVersion,
- gpu_info.driver_version);
- base::debug::SetCrashKeyValue(crash_keys::kGPUPixelShaderVersion,
- gpu_info.pixel_shader_version);
- base::debug::SetCrashKeyValue(crash_keys::kGPUVertexShaderVersion,
- gpu_info.vertex_shader_version);
-#if defined(OS_MACOSX)
- base::debug::SetCrashKeyValue(crash_keys::kGPUGLVersion, gpu_info.gl_version);
-#elif defined(OS_POSIX)
- base::debug::SetCrashKeyValue(crash_keys::kGPUVendor, gpu_info.gl_vendor);
- base::debug::SetCrashKeyValue(crash_keys::kGPURenderer, gpu_info.gl_renderer);
-#endif
+ gpu::SetKeysForCrashLogging(gpu_info);
}
#if BUILDFLAG(ENABLE_PLUGINS)
« no previous file with comments | « chrome/common/BUILD.gn ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698