Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: runtime/vm/intermediate_language.h

Issue 2751103003: VM: Propagate non-nullness from instance calls. (Closed)
Patch Set: canonicalize redundant redefinitions Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 02aed911e21405d4645f34bcafc9a2631c34d047..d0e84e846d30867a45c439219b7bea8c49db284d 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -2409,7 +2409,7 @@ class DeoptimizeInstr : public TemplateInstruction<0, NoThrow, Pure> {
class RedefinitionInstr : public TemplateDefinition<1, NoThrow> {
public:
- explicit RedefinitionInstr(Value* value) : type_(NULL) {
+ explicit RedefinitionInstr(Value* value) : constrained_type_(NULL) {
SetInputAt(0, value);
}
@@ -2420,15 +2420,17 @@ class RedefinitionInstr : public TemplateDefinition<1, NoThrow> {
virtual CompileType ComputeType() const;
virtual bool RecomputeType();
- void set_type(CompileType* type) { type_ = type; }
- CompileType* type() const { return type_; }
+ virtual Definition* Canonicalize(FlowGraph* flow_graph);
+
+ void set_constrained_type(CompileType* type) { constrained_type_ = type; }
+ CompileType* constrained_type() const { return constrained_type_; }
virtual bool CanDeoptimize() const { return false; }
virtual EffectSet Dependencies() const { return EffectSet::None(); }
virtual EffectSet Effects() const { return EffectSet::None(); }
private:
- CompileType* type_;
+ CompileType* constrained_type_;
DISALLOW_COPY_AND_ASSIGN(RedefinitionInstr);
};
« no previous file with comments | « runtime/vm/flow_graph_type_propagator.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698