Issue 2751093004: [fasta] Flip source flag and include source by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2751093004: [fasta] Flip source flag and include source by default (Closed)

Created:
3 years, 9 months ago by jensj

Modified:
3 years, 9 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	pkg/front_end/lib/src/fasta/compiler_command_line.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	pkg/front_end/lib/src/fasta/source/source_loader.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

jensj

Patch ran on golumn, though I'm not sure how to read the result...

3 years, 9 months ago (2017-03-16 10:56:38 UTC) #2

jensj

with help from Slava (paraphrasing) "probably the same, maybe up to 1% slower but I ...

3 years, 9 months ago (2017-03-16 11:10:30 UTC) #3

jensj

3 years, 9 months ago (2017-03-20 07:21:26 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ee7fe44941595a8cfd0244d3eb3bbcae6954c292 (presubmit successful).