Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: components/ntp_snippets/remote/remote_suggestions_fetcher.cc

Issue 2751093003: Unifies the additional actions for Categories (Closed)
Patch Set: Fix compilation on Android (hopefully) Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/remote/remote_suggestions_fetcher.cc
diff --git a/components/ntp_snippets/remote/remote_suggestions_fetcher.cc b/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
index 17ebaa7d3049d09581cb6748daae0855c182c931..992f05c30d91241ac4b4560b237bca701ed9e892 100644
--- a/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
+++ b/components/ntp_snippets/remote/remote_suggestions_fetcher.cc
@@ -216,18 +216,20 @@ CategoryInfo BuildArticleCategoryInfo(
: l10n_util::GetStringUTF16(
IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_HEADER),
ContentSuggestionsCardLayout::FULL_CARD,
- /*has_fetch_action=*/true,
- /*has_view_all_action=*/false,
+ ContentSuggestionsAdditionalAction::FETCH,
/*show_if_empty=*/true,
l10n_util::GetStringUTF16(IDS_NTP_ARTICLE_SUGGESTIONS_SECTION_EMPTY));
}
CategoryInfo BuildRemoteCategoryInfo(const base::string16& title,
bool allow_fetching_more_results) {
+ ContentSuggestionsAdditionalAction action =
+ ContentSuggestionsAdditionalAction::NONE;
+ if (allow_fetching_more_results) {
+ action = ContentSuggestionsAdditionalAction::FETCH;
+ }
return CategoryInfo(
- title, ContentSuggestionsCardLayout::FULL_CARD,
- /*has_fetch_action=*/allow_fetching_more_results,
- /*has_view_all_action=*/false,
+ title, ContentSuggestionsCardLayout::FULL_CARD, action,
/*show_if_empty=*/false,
// TODO(tschumann): The message for no-articles is likely wrong
// and needs to be added to the stubby protocol if we want to
« no previous file with comments | « components/ntp_snippets/remote/json_request.cc ('k') | components/ntp_snippets/remote/remote_suggestions_fetcher_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698