components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc - Issue 2751093003: Unifies the additional actions for Categories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2751093003: Unifies the additional actions for Categories (Closed)

Patch Set: Fix compilation on Android (hopefully) Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc ('k') | components/ntp_snippets/remote/json_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

index 7dc4615aa4348a0dd4810d5260b39b1c434d2f78..3f32e9e453f0e8c8cc32a5ff1d8cd4c3ce5f590c 100644

--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

@@ -117,8 +117,7 @@ CategoryInfo PhysicalWebPageSuggestionsProvider::GetCategoryInfo(

return CategoryInfo(l10n_util::GetStringUTF16(

IDS_NTP_PHYSICAL_WEB_PAGE_SUGGESTIONS_SECTION_HEADER),

ContentSuggestionsCardLayout::FULL_CARD,

- /*has_fetch_action=*/false,

- /*has_view_all_action=*/false,

+ ContentSuggestionsAdditionalAction::NONE,

/*show_if_empty=*/false,

l10n_util::GetStringUTF16(

IDS_NTP_PHYSICAL_WEB_PAGE_SUGGESTIONS_SECTION_EMPTY));