Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2384)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java

Issue 2751093003: Unifies the additional actions for Categories (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
index 15d272e599da19b0e3474cf2ad531d968a0a7003..7d705d4f8ede42fd7532e9145224ef8feb8cc157 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
@@ -12,6 +12,8 @@ import org.chromium.chrome.browser.ntp.NewTabPageUma;
import org.chromium.chrome.browser.ntp.cards.ActionItem;
import org.chromium.chrome.browser.ntp.cards.SuggestionsCategoryInfo;
import org.chromium.chrome.browser.ntp.snippets.CategoryStatus.CategoryStatusEnum;
+import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsAdditionalAction.ContentSuggestionsAdditionalActionEnum;
+import org.chromium.chrome.browser.ntp.snippets.ContentSuggestionsCardLayout.ContentSuggestionsCardLayoutEnum;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.suggestions.DestructionObserver;
import org.chromium.chrome.browser.suggestions.SuggestionsMetricsReporter;
@@ -289,8 +291,11 @@ public class SnippetsBridge
@CalledByNative
private static SuggestionsCategoryInfo createSuggestionsCategoryInfo(int category, String title,
- int cardLayout, boolean hasFetchAction, boolean hasViewAllAction, boolean showIfEmpty,
+ @ContentSuggestionsCardLayoutEnum int cardLayout,
+ @ContentSuggestionsAdditionalActionEnum int additionalAction, boolean showIfEmpty,
String noSuggestionsMessage) {
+ boolean hasFetchAction = additionalAction == ContentSuggestionsAdditionalAction.FETCH;
+ boolean hasViewAllAction = additionalAction == ContentSuggestionsAdditionalAction.VIEW_ALL;
return new SuggestionsCategoryInfo(category, title, cardLayout, hasFetchAction,
hasViewAllAction, showIfEmpty, noSuggestionsMessage);
}
« no previous file with comments | « no previous file | chrome/browser/android/ntp/ntp_snippets_bridge.cc » ('j') | components/ntp_snippets/category_info.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698