Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: runtime/vm/kernel_binary.cc

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/observatory/tests/service/step_through_property_set_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 #if !defined(DART_PRECOMPILED_RUNTIME) 4 #if !defined(DART_PRECOMPILED_RUNTIME)
5 5
6 #include "platform/globals.h" 6 #include "platform/globals.h"
7 #include "vm/flags.h" 7 #include "vm/flags.h"
8 #include "vm/growable_array.h" 8 #include "vm/growable_array.h"
9 #include "vm/kernel.h" 9 #include "vm/kernel.h"
10 #include "vm/kernel_to_il.h" 10 #include "vm/kernel_to_il.h"
(...skipping 1078 matching lines...) Expand 10 before | Expand all | Expand 10 after
1089 set->name_ = Name::ReadFrom(reader); 1089 set->name_ = Name::ReadFrom(reader);
1090 set->value_ = Expression::ReadFrom(reader); 1090 set->value_ = Expression::ReadFrom(reader);
1091 set->interface_target_reference_ = Reference::ReadMemberFrom(reader, true); 1091 set->interface_target_reference_ = Reference::ReadMemberFrom(reader, true);
1092 return set; 1092 return set;
1093 } 1093 }
1094 1094
1095 1095
1096 DirectPropertyGet* DirectPropertyGet::ReadFrom(Reader* reader) { 1096 DirectPropertyGet* DirectPropertyGet::ReadFrom(Reader* reader) {
1097 TRACE_READ_OFFSET(); 1097 TRACE_READ_OFFSET();
1098 DirectPropertyGet* get = new DirectPropertyGet(); 1098 DirectPropertyGet* get = new DirectPropertyGet();
1099 get->position_ = reader->ReadPosition();
1100 get->receiver_ = Expression::ReadFrom(reader); 1099 get->receiver_ = Expression::ReadFrom(reader);
1101 get->target_reference_ = Reference::ReadMemberFrom(reader); 1100 get->target_reference_ = Reference::ReadMemberFrom(reader);
1102 return get; 1101 return get;
1103 } 1102 }
1104 1103
1105 1104
1106 DirectPropertySet* DirectPropertySet::ReadFrom(Reader* reader) { 1105 DirectPropertySet* DirectPropertySet::ReadFrom(Reader* reader) {
1107 TRACE_READ_OFFSET(); 1106 TRACE_READ_OFFSET();
1108 DirectPropertySet* set = new DirectPropertySet(); 1107 DirectPropertySet* set = new DirectPropertySet();
1109 set->position_ = reader->ReadPosition();
1110 set->receiver_ = Expression::ReadFrom(reader); 1108 set->receiver_ = Expression::ReadFrom(reader);
1111 set->target_reference_ = Reference::ReadMemberFrom(reader); 1109 set->target_reference_ = Reference::ReadMemberFrom(reader);
1112 set->value_ = Expression::ReadFrom(reader); 1110 set->value_ = Expression::ReadFrom(reader);
1113 return set; 1111 return set;
1114 } 1112 }
1115 1113
1116 1114
1117 StaticGet* StaticGet::ReadFrom(Reader* reader) { 1115 StaticGet* StaticGet::ReadFrom(Reader* reader) {
1118 TRACE_READ_OFFSET(); 1116 TRACE_READ_OFFSET();
1119 StaticGet* get = new StaticGet(); 1117 StaticGet* get = new StaticGet();
(...skipping 818 matching lines...) Expand 10 before | Expand all | Expand 10 after
1938 1936
1939 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer, 1937 kernel::Program* ReadPrecompiledKernelFromBuffer(const uint8_t* buffer,
1940 intptr_t buffer_length) { 1938 intptr_t buffer_length) {
1941 kernel::Reader reader(buffer, buffer_length); 1939 kernel::Reader reader(buffer, buffer_length);
1942 return kernel::Program::ReadFrom(&reader); 1940 return kernel::Program::ReadFrom(&reader);
1943 } 1941 }
1944 1942
1945 1943
1946 } // namespace dart 1944 } // namespace dart
1947 #endif // !defined(DART_PRECOMPILED_RUNTIME) 1945 #endif // !defined(DART_PRECOMPILED_RUNTIME)
OLDNEW
« no previous file with comments | « runtime/observatory/tests/service/step_through_property_set_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698