Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 275103009: gclient: fix --delete_unversioned_trees bug (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
Reviewers:
iannucci
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

gclient: fix --delete_unversioned_trees bug This occurs for svn checkouts when the DEPS change from: third_party/skia/gyp third_party/skia/include third_party/skia/src to: third_party/skia First, gclient deletes/moves third_party/skia to make room for the new checkout. When finished, it notices that the three subdirectories under skia are now "unversioned" according to .gclient_entries, even though they are part of Skia repo. On the bots, this causes them to be deleted. There is a check to determine whether the thought-to-be unversioned directories are actually subdirectories of another checkout, but it doesn't work in the svn case because the check assumes that, if they are subdirectories of another checkout, it must be an svn checkout. scm.GetCheckoutRoot() returns None because it can't find an svn checkout containing those subdirectories. None is not in gclient_entries, so the directories get deleted. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=270133

Patch Set 1 #

Patch Set 2 : try GIT and SVn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M gclient.py View 1 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
borenet
This is causing failures on (try)bots with svn checkouts for my DEPS change: https://codereview.chromium.org/275893002/
6 years, 7 months ago (2014-05-13 16:51:54 UTC) #1
iannucci
lgtm
6 years, 7 months ago (2014-05-13 17:25:32 UTC) #2
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-13 17:26:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/275103009/20001
6 years, 7 months ago (2014-05-13 17:26:36 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 17:28:20 UTC) #5
Message was sent while issue was closed.
Change committed as 270133

Powered by Google App Engine
This is Rietveld 408576698