content/browser/service_worker/service_worker_registration_status.cc - Issue 275103004: ServiceWorker: Database functions should return status code instead of boolean

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/service_worker/service_worker_registration_status.cc

Issue 275103004: ServiceWorker: Database functions should return status code instead of boolean (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « content/browser/service_worker/service_worker_database_unittest.cc ('k') | content/browser/service_worker/service_worker_storage.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "content/browser/service_worker/service_worker_registration_status.h"	5 #include "content/browser/service_worker/service_worker_registration_status.h"

6	6

7 #include "base/logging.h"	7 #include "base/logging.h"

8 #include "base/strings/utf_string_conversions.h"	8 #include "base/strings/utf_string_conversions.h"

9	9

10 namespace content {	10 namespace content {

(...skipping 22 matching lines...) Expand all Loading...
33	33

34 case SERVICE_WORKER_ERROR_NOT_FOUND:	34 case SERVICE_WORKER_ERROR_NOT_FOUND:

35 *error_type = WebServiceWorkerError::NotFoundError;	35 *error_type = WebServiceWorkerError::NotFoundError;

36 return;	36 return;

37	37

38 case SERVICE_WORKER_ERROR_ABORT:	38 case SERVICE_WORKER_ERROR_ABORT:

39 case SERVICE_WORKER_ERROR_IPC_FAILED:	39 case SERVICE_WORKER_ERROR_IPC_FAILED:

40 case SERVICE_WORKER_ERROR_FAILED:	40 case SERVICE_WORKER_ERROR_FAILED:

41 case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:	41 case SERVICE_WORKER_ERROR_PROCESS_NOT_FOUND:

42 case SERVICE_WORKER_ERROR_EXISTS:	42 case SERVICE_WORKER_ERROR_EXISTS:

	43 case SERVICE_WORKER_ERROR_DB_CORRUPTED:

43 // Unexpected, or should have bailed out before calling this, or we don't	44 // Unexpected, or should have bailed out before calling this, or we don't

44 // have a corresponding blink error code yet.	45 // have a corresponding blink error code yet.

45 break; // Fall through to NOTREACHED().	46 break; // Fall through to NOTREACHED().

46 }	47 }

47 NOTREACHED() << "Got unexpected error code: "	48 NOTREACHED() << "Got unexpected error code: "

48 << status << " " << ServiceWorkerStatusToString(status);	49 << status << " " << ServiceWorkerStatusToString(status);

49 }	50 }

50	51

51 } // namespace content	52 } // namespace content

OLD	NEW