Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2751023003: SPv2: Enable remaining svg/animations tests. (Closed)

Created:
3 years, 9 months ago by wkorman
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SPv2: Enable remaining svg/animations tests. BUG=666986

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
wkorman
These looked the same to me with minor pixel differences perhaps due to layerization. I ...
3 years, 9 months ago (2017-03-15 21:19:57 UTC) #2
pdr.
On 2017/03/15 at 21:19:57, wkorman wrote: > These looked the same to me with minor ...
3 years, 9 months ago (2017-03-15 22:17:27 UTC) #3
wkorman
3 years, 9 months ago (2017-03-17 20:38:46 UTC) #4
On 2017/03/15 22:17:27, pdr. wrote:
> On 2017/03/15 at 21:19:57, wkorman wrote:
> > These looked the same to me with minor pixel differences perhaps due to
> layerization. I kicked off a try job so that we can review again together.
> 
> If possible I'd like to have no pixel differences. Do you know where they are
> coming from?

Discussed briefly in person, I will investigate, I was partly following what
looked like similar already done in:

https://codereview.chromium.org/2443843003/

ex. for compositing/geometry/layer-due-to-layer-children-deep.html

Powered by Google App Engine
This is Rietveld 408576698