chrome/browser/extensions/extension_browsertest.h - Issue 2751013002: Simplify ExtensionInstallChecker into a single-use class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.h

Issue 2751013002: Simplify ExtensionInstallChecker into a single-use class (Closed)

Patch Set: rebase on enable_extensions=0 fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browsertest.h

diff --git a/chrome/browser/extensions/extension_browsertest.h b/chrome/browser/extensions/extension_browsertest.h

index 55eecc6c657f2b5cec2930e5376bd1324800c9c4..ca8782035a7b5d54a4a33a439f26fda2e94ac1d1 100644

--- a/chrome/browser/extensions/extension_browsertest.h

+++ b/chrome/browser/extensions/extension_browsertest.h

@@ -263,7 +263,8 @@ class ExtensionBrowserTest : virtual public InProcessBrowserTest {

return observer_->WaitForExtensionCrash(extension_id);

}

- // Wait for the crx installer to be done. Returns true if it really is done.

+ // Wait for the crx installer to be done. Returns true if it has finished

+ // successfully.

bool WaitForCrxInstallerDone() {

Devlin 2017/03/20 15:36:46 nit: WaitForCrxInstallerSuccess() to reflect this

michaelpg 2017/03/22 00:17:12 well, it still waits for it to be done, not for it

return observer_->WaitForCrxInstallerDone();

}