Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: chrome/browser/extensions/crx_installer_browsertest.cc

Issue 2751013002: Simplify ExtensionInstallChecker into a single-use class (Closed)
Patch Set: todo Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer_browsertest.cc
diff --git a/chrome/browser/extensions/crx_installer_browsertest.cc b/chrome/browser/extensions/crx_installer_browsertest.cc
index 36098b82f44caf7686064726b18bea1e18e82006..af7b9e43094af44b85ddf37d6fb70441bee034db 100644
--- a/chrome/browser/extensions/crx_installer_browsertest.cc
+++ b/chrome/browser/extensions/crx_installer_browsertest.cc
@@ -284,16 +284,6 @@ class ExtensionCrxInstallerTest : public ExtensionBrowserTest {
CreateWebAppInfo(kAppTitle, kAppDescription, kAppUrl, 64));
EXPECT_TRUE(WaitForCrxInstallerDone());
ASSERT_TRUE(crx_installer->extension());
- ASSERT_FALSE(HasRequirementErrors(crx_installer.get()));
- ASSERT_FALSE(HasPolicyErrors(crx_installer.get()));
- }
-
- bool HasRequirementErrors(CrxInstaller* crx_installer) {
- return !crx_installer->install_checker_.requirement_errors().empty();
- }
-
- bool HasPolicyErrors(CrxInstaller* crx_installer) {
- return !crx_installer->install_checker_.policy_error().empty();
}
};
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/extensions/extension_browsertest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698