sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart - Issue 27510003: Scanner for UTF-8 byte arrays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart

Issue 27510003: Scanner for UTF-8 byte arrays (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Re-add ArrayBasedScanner, minor fixes. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sdk/lib/_internal/compiler/implementation/apiimpl.dart ('K') | « sdk/lib/_internal/compiler/implementation/js_emitter/js_emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/patch_parser.dart » ('j') | sdk/lib/_internal/compiler/implementation/scanner/scanner.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart b/sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart

index 8b06802f75968006c6f681bf9f7f402d9d08045d..e57aeabd0036bf313310091c77918f9525ac7a99 100644

--- a/sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirror_renamer/renamer.dart

@@ -86,7 +86,7 @@ class MirrorRenamer {

sb.write(symbols[mangledName]);

sb.write("'");

}

- sb.write('};');

+ sb.write('};\x00'); // Terminate the string with '0', see [StringScanner].

kasperl 2013/10/17 08:50:39 Would it be easier to read if you did sb.writeChar

lukas 2013/10/17 17:49:34 Sure.

topLevelNodes.add(parse(sb.toString()));

// Replace calls to Mirrorsystem.getName with calls to helper function.