Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart

Issue 27510002: Add a much simplified set implementation designed to waste little memory for small sets. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address feedback. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
diff --git a/sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart b/sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
index 3c2a39ccf81c6f29a885eef917a695736c76bf85..99446a25e7613c09cd73cd1bb3770539d70fe90d 100644
--- a/sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
+++ b/sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
@@ -13,7 +13,7 @@ import '../universe/universe.dart' show Selector, TypedSelector, SideEffects;
import '../dart2jslib.dart' show Compiler, SourceString, TreeElementMapping;
import 'inferrer_visitor.dart' show TypeSystem, ArgumentsTypes;
import '../native_handler.dart' as native;
-import '../util/util.dart' show Spannable;
+import '../util/util.dart' show Spannable, Setlet;
import 'simple_types_inferrer.dart';
import '../dart2jslib.dart' show invariant;
@@ -342,7 +342,7 @@ class WorkQueue {
element.inQueue = true;
}
- void addAll(Iterable<TypeInformation> all) {
+ void addAll(all) {
all.forEach(add);
}
@@ -723,7 +723,7 @@ class TypeGraphInferrerEngine
// [SimpleTypesInferrer].
Iterable<Element> sortResolvedElements() {
int max = 0;
- Map<int, Set<Element>> methodSizes = new Map<int, Set<Element>>();
+ Map<int, Setlet<Element>> methodSizes = new Map<int, Setlet<Element>>();
compiler.enqueuer.resolution.resolvedElements.forEach(
(Element element, TreeElementMapping mapping) {
element = element.implementation;
@@ -743,17 +743,16 @@ class TypeGraphInferrerEngine
// length order.
int length = mapping.selectors.length;
max = length > max ? length : max;
- Set<Element> set = methodSizes.putIfAbsent(
- length, () => new Set<Element>());
+ Setlet<Element> set = methodSizes.putIfAbsent(
+ length, () => new Setlet<Element>());
set.add(element);
});
List<Element> result = <Element>[];
-
for (int i = 0; i <= max; i++) {
- Set<Element> set = methodSizes[i];
+ Setlet<Element> set = methodSizes[i];
if (set != null) {
- result.addAll(set);
+ set.forEach((each) => result.add(each));
}
}
return result;

Powered by Google App Engine
This is Rietveld 408576698