third_party/WebKit/LayoutTests/fast/xsl/xslt-node-set-empty.html - Issue 2750943004: node-set($x), when $x is empty, should not halt XSLT processing

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/xsl/xslt-node-set-empty.html

Issue 2750943004: node-set($x), when $x is empty, should not halt XSLT processing (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 test(() => {

	6 var xmlSource = '<go/>';

	7 var xslSource = `<xsl:stylesheet version="1.0"

	8 xmlns:xsl="http://www.w3.org/1999/XSL/Transform"

	9 xmlns:exsl="http://exslt.org/common"

	10 exclude-result-prefixes="exsl">
	yosin_UTC9 2017/03/15 07:47:24 We don't need to have exclude-result-prefixes sinc We don't need to have exclude-result-prefixes since this test doesn't intent to test this feature.
	11

	12 <xsl:variable name="empty"></xsl:variable>

	13 <xsl:variable name="look" select="exsl:node-set($empty)"/>
	yosin_UTC9 2017/03/15 07:47:24 Can we write this just \|exsl:node-set('')\|? Can we write this just \|exsl:node-set('')\|? dominicc (has gone to gerrit) 2017/03/16 09:23:42 Yes, done. Show quoted text On 2017/03/15 at 07:47:24, yosin_UTC9 wrote: > Can we write this just \|exsl:node-set('')\|? Yes, done.
	14

	15 <xsl:template match="go">

	16 <xsl:text>PASS</xsl:text>
	yosin_UTC9 2017/03/15 07:47:24 Rather than checking whether crash or not, checkin Rather than checking whether crash or not, checking value return of of exsl:node-set() is more useful. e.g string-length(node-set('')) = <xsl:value-of select="string-length(node-set('')"> dominicc (has gone to gerrit) 2017/03/16 09:23:42 This unfortunately doesn't work. The thing which h Show quoted text On 2017/03/15 at 07:47:24, yosin_UTC9 wrote: > Rather than checking whether crash or not, checking value return of of exsl:node-set() is more useful. > > e.g > > string-length(node-set('')) = <xsl:value-of select="string-length(node-set('')"> This unfortunately doesn't work. The thing which halts processing prematurely is the function that's evaluating the expressions to populate variables; in a value-of expression, node-set('') works.
	17 </xsl:template>

	18 </xsl:stylesheet>`;

	19

	20 let parser = new DOMParser();

	21 let xsl = parser.parseFromString(xslSource, 'text/xml');

	22 let xml = parser.parseFromString(xmlSource, 'text/xml');

	23

	24 let xslproc = new XSLTProcessor();
	yosin_UTC9 2017/03/15 07:47:24 nit: s/let/const/ nit: s/let/const/
	25 xslproc.importStylesheet(xsl);

	26 let result = xslproc.transformToFragment(xml, document);
	yosin_UTC9 2017/03/15 07:47:24 nit: s/let/const/ nit: s/let/const/
	27 assert_equals(result.firstChild.textContent, 'PASS');

	28 }, 'node-set of an empty variable should not halt processing');

	29 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/xml/XSLTExtensions.cpp » ('j') | no next file with comments »