Issue 27509002: Get rid of custom code for HTMLLinkElement.sizes attribute setter

Issue 27509002: Get rid of custom code for HTMLLinkElement.sizes attribute setter (Closed)

Created:
7 years, 2 months ago by Inactive

Modified:
7 years, 2 months ago

Reviewers:
haraken, abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, gavinp+prerender_chromium.org, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, Nate Chapin

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Get rid of custom code for HTMLLinkElement.sizes attribute setter Get rid of custom code for HTMLLinkElement.sizes attribute setter by leveraging bindings generator support for [PutForwards=x] IDL extended attribute support. The IDL now matches the specification as well: http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#htmllinkelement BUG=307045 R=haraken TEST=fast/dom/icon-size-property.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159816

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -52 lines)			Patch
M	Source/bindings/bindings.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	Source/bindings/v8/custom/V8HTMLLinkElementCustom.cpp	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	Source/core/html/HTMLLinkElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLLinkElement.cpp	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	Source/core/html/HTMLLinkElement.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Inactive

The diff for V8HTMLLinkElement.cpp is available at: http://pastebin.com/aBngtx7S

7 years, 2 months ago (2013-10-16 13:45:07 UTC) #1

haraken

LGTM. PutForwards are awesome! Please just check that we have a test case for the ...

7 years, 2 months ago (2013-10-16 15:06:49 UTC) #2

Inactive

On 2013/10/16 15:06:49, haraken wrote: > LGTM. PutForwards are awesome! > > Please just check ...

7 years, 2 months ago (2013-10-16 15:17:48 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27509002/1

7 years, 2 months ago (2013-10-16 15:18:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27509002/1

7 years, 2 months ago (2013-10-16 20:41:56 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/27509002/1

7 years, 2 months ago (2013-10-17 01:36:17 UTC) #7

Message was sent while issue was closed.

Change committed as 159816

Expand Messages | Collapse Messages