Complain about built-in identifiers.

pkg/front_end/lib/src/fasta/scanner/token.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.scanner.token;
 
 import 'keyword.dart' show Keyword;
 
 import 'precedence.dart' show BAD_INPUT_INFO, EOF_INFO, PrecedenceInfo;
 
@@ skipping 105 matching lines @@
       return 1;
     } else {
       return lexeme.length;
     }
   }
 
   /// The character offset of the end of this token within the source text.
   int get charEnd => charOffset + charCount;
 
   bool get isEof => false;
+
+  bool get isBuiltInIdentifier => false;
 }
 
 /**
  * A [SymbolToken] represents the symbol in its precedence info.
  * Also used for end of file with EOF_INFO.
  */
 class SymbolToken extends Token {
   final PrecedenceInfo info;
 
   SymbolToken(this.info, int charOffset) : super(charOffset);
@@ skipping 31 matching lines @@
   KeywordToken(this.keyword, int charOffset) : super(charOffset);
 
   PrecedenceInfo get info => keyword.info;
 
   String get lexeme => keyword.syntax;
 
   String get stringValue => keyword.syntax;
 
   bool isIdentifier() => keyword.isPseudo || keyword.isBuiltIn;
 
+  bool get isBuiltInIdentifier {
+    return keyword.isBuiltIn || identical("deferred", lexeme);

[danrubel, 2017/03/14 15:21:43]

Similar to what Paul recommended in the fasta.Keyword CL (see link below), I
suggest we add the following comment here.

// TODO: remove `identical("deferred", lexeme)` once dartbug.com/29069 is fixed.


https://codereview.chromium.org/2746023003/diff/40001/pkg/front_end/lib/src/f...

[ahe, 2017/03/14 15:24:35]

Yes. That's how I knew about this case :-)

I'll add the todo.

+  }
+
   String toString() => "KeywordToken($lexeme)";
 }
 
 /**
  * A String-valued token. Represents identifiers, string literals,
  * number literals, comments, and error tokens, using the corresponding
  * precedence info.
  */
 class StringToken extends Token {
   /**
@@ skipping 181 matching lines @@
       identical(value, "<=") ||
       identical(value, "<") ||
       identical(value, "&") ||
       identical(value, "^") ||
       identical(value, "|");
 }
 
 bool isTernaryOperator(String value) => identical(value, "[]=");
 
 bool isMinusOperator(String value) => identical(value, "-");