Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: third_party/WebKit/Source/core/html/TextControlElement.h

Issue 2750833002: TextControlElement::selection() should return SelectionInDOMTree. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/TextControlElement.h
diff --git a/third_party/WebKit/Source/core/html/TextControlElement.h b/third_party/WebKit/Source/core/html/TextControlElement.h
index 8667c1ff259bf92e819da9fa2c7c120b14fa2c63..9bc98c459522ce662762b847b6a75ec1ec1ddd75 100644
--- a/third_party/WebKit/Source/core/html/TextControlElement.h
+++ b/third_party/WebKit/Source/core/html/TextControlElement.h
@@ -28,13 +28,12 @@
#include "base/gtest_prod_util.h"
#include "core/CoreExport.h"
+#include "core/editing/SelectionTemplate.h"
#include "core/editing/VisiblePosition.h"
#include "core/html/HTMLFormControlElementWithState.h"
-
namespace blink {
Shanmuga Pandi 2017/03/14 14:31:48 Keep empty line as it is.
tanvir 2017/03/14 14:59:36 Done.
class ExceptionState;
-class Range;
enum TextFieldSelectionDirection {
SelectionHasNoDirection,
@@ -100,7 +99,7 @@ class CORE_EXPORT TextControlElement : public HTMLFormControlElementWithState {
bool setSelectionRange(unsigned start,
unsigned end,
TextFieldSelectionDirection = SelectionHasNoDirection);
- Range* selection() const;
+ const SelectionInDOMTree selection() const;
virtual bool supportsAutocapitalize() const = 0;
virtual const AtomicString& defaultAutocapitalize() const = 0;

Powered by Google App Engine
This is Rietveld 408576698