TextControlElement::selection() should return SelectionInDOMTree.

third_party/WebKit/Source/core/html/TextControlElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 10 matching lines @@
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef TextControlElement_h
 #define TextControlElement_h
 
 #include "base/gtest_prod_util.h"
 #include "core/CoreExport.h"
+#include "core/editing/SelectionTemplate.h"
 #include "core/editing/VisiblePosition.h"
 #include "core/html/HTMLFormControlElementWithState.h"
 
 namespace blink {
 
 class ExceptionState;
-class Range;
 
 enum TextFieldSelectionDirection {
   SelectionHasNoDirection,
   SelectionHasForwardDirection,
   SelectionHasBackwardDirection
 };
 enum TextFieldEventBehavior {
   DispatchNoEvent,
   DispatchChangeEvent,
   DispatchInputAndChangeEvent
@@ skipping 45 matching lines @@
   // 'select' event.
   void setSelectionRangeForBinding(unsigned start,
                                    unsigned end,
                                    const String& direction = "none");
   // Blink-internal version of setSelectionRange(). This translates "none"
   // direction to "forward" on platforms without "none" direction.
   // This returns true if it updated cached selection and/or FrameSelection.
   bool setSelectionRange(unsigned start,
                          unsigned end,
                          TextFieldSelectionDirection = SelectionHasNoDirection);
-  Range* selection() const;
+  const SelectionInDOMTree selection() const;

[yosin_UTC9, 2017/03/15 09:29:28]

nit: s/const SelecitonInDOMTree/SelectionInDOMTree/

[tanvir, 2017/03/15 10:18:15]

Done.

 
   virtual bool supportsAutocapitalize() const = 0;
   virtual const AtomicString& defaultAutocapitalize() const = 0;
   const AtomicString& autocapitalize() const;
   void setAutocapitalize(const AtomicString&);
 
   int maxLength() const;
   int minLength() const;
   void setMaxLength(int, ExceptionState&);
   void setMinLength(int, ExceptionState&);
@@ skipping 99 matching lines @@
 }
 
 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(TextControlElement);
 
 TextControlElement* enclosingTextControl(const Position&);
 TextControlElement* enclosingTextControl(const Node*);
 
 }  // namespace blink
 
 #endif