Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2750813002: cleanup duplicate fasta scanner methods (Closed)

Created:
3 years, 9 months ago by danrubel
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart View 1 chunk +2 lines, -2 lines 2 comments Download
M pkg/front_end/lib/src/fasta/scanner/string_scanner.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scanner/utf8_bytes_scanner.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
3 years, 9 months ago (2017-03-14 12:52:21 UTC) #2
ahe
lgtm https://codereview.chromium.org/2750813002/diff/1/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right): https://codereview.chromium.org/2750813002/diff/1/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart#newcode142 pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:142: Token previousToken() => tail; I think we can ...
3 years, 9 months ago (2017-03-14 14:09:28 UTC) #3
Paul Berry
lgtm
3 years, 9 months ago (2017-03-14 14:55:38 UTC) #4
danrubel
https://codereview.chromium.org/2750813002/diff/1/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart File pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart (right): https://codereview.chromium.org/2750813002/diff/1/pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart#newcode142 pkg/front_end/lib/src/fasta/scanner/abstract_scanner.dart:142: Token previousToken() => tail; On 2017/03/14 14:09:27, ahe wrote: ...
3 years, 9 months ago (2017-03-14 16:55:16 UTC) #5
danrubel
3 years, 9 months ago (2017-03-14 16:57:17 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9c30d9ddb6c03796aaa33e94ce5a74458dad2017 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698