| OLD | NEW |
|---|
| 1 [ | 1 [ |
| 2 { | 2 { |
| 3 "cmd": [ | 3 "cmd": [ |
| 4 "echo", | 4 "echo", |
| 5 "[1, 2, 3]" | 5 "[1, 2, 3]" |
| 6 ], | 6 ], |
| 7 "name": "echo1", | 7 "name": "echo1", |
| 8 "stdout": "/path/to/tmp/json", | 8 "stdout": "/path/to/tmp/json", |
| 9 "~followup_annotations": [ | 9 "~followup_annotations": [ |
| 10 "@@@STEP_LOG_LINE@json.output@[@@@", | 10 "@@@STEP_LOG_LINE@json.output@[@@@", |
| (...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 97 "name": "read json from file we just wrote", | 97 "name": "read json from file we just wrote", |
| 98 "~followup_annotations": [ | 98 "~followup_annotations": [ |
| 99 "@@@STEP_LOG_LINE@json.output@{@@@", | 99 "@@@STEP_LOG_LINE@json.output@{@@@", |
| 100 "@@@STEP_LOG_LINE@json.output@ \"x\": 1, @@@", | 100 "@@@STEP_LOG_LINE@json.output@ \"x\": 1, @@@", |
| 101 "@@@STEP_LOG_LINE@json.output@ \"y\": 2@@@", | 101 "@@@STEP_LOG_LINE@json.output@ \"y\": 2@@@", |
| 102 "@@@STEP_LOG_LINE@json.output@}@@@", | 102 "@@@STEP_LOG_LINE@json.output@}@@@", |
| 103 "@@@STEP_LOG_END@json.output@@@" | 103 "@@@STEP_LOG_END@json.output@@@" |
| 104 ] | 104 ] |
| 105 }, | 105 }, |
| 106 { | 106 { |
| 107 "cmd": [ |
| 108 "python", |
| 109 "RECIPE[recipe_engine::json:example].resources/cool_script.py", |
| 110 "{\"x\":1,\"y\":2}", |
| 111 "[TMP_BASE]/leak.json" |
| 112 ], |
| 113 "name": "leaking json", |
| 114 "~followup_annotations": [ |
| 115 "@@@STEP_LOG_LINE@json.output@{@@@", |
| 116 "@@@STEP_LOG_LINE@json.output@ \"x\": 1, @@@", |
| 117 "@@@STEP_LOG_LINE@json.output@ \"y\": 2@@@", |
| 118 "@@@STEP_LOG_LINE@json.output@}@@@", |
| 119 "@@@STEP_LOG_END@json.output@@@" |
| 120 ] |
| 121 }, |
| 122 { |
| 123 "cmd": [ |
| 124 "python", |
| 125 "RECIPE[recipe_engine::json:example].resources/cool_script.py", |
| 126 "{\"here is some total\ngarbage", |
| 127 "/path/to/tmp/json" |
| 128 ], |
| 129 "name": "invalid json", |
| 130 "~followup_annotations": [ |
| 131 "@@@STEP_LOG_LINE@json.output (invalid)@{\"here is some total@@@", |
| 132 "@@@STEP_LOG_LINE@json.output (invalid)@garbage@@@", |
| 133 "@@@STEP_LOG_END@json.output (invalid)@@@", |
| 134 "@@@STEP_LOG_LINE@json.output (exception)@Invalid control character at: li
ne 1 column 21 (char 20)@@@", |
| 135 "@@@STEP_LOG_END@json.output (exception)@@@" |
| 136 ] |
| 137 }, |
| 138 { |
| 107 "name": "$result", | 139 "name": "$result", |
| 108 "recipe_result": null, | 140 "recipe_result": null, |
| 109 "status_code": 0 | 141 "status_code": 0 |
| 110 } | 142 } |
| 111 ] | 143 ] |
| OLD | NEW |
|---|
Chromium Code Reviews
Issue 2750793002:
[json] improve output to get leak_to and better logging. (Closed)
