content/browser/download/download_file.h - Issue 2750713003: Add UMA for estimating disk bandwidth and the time saved with parallel download

Side by Side Diff: content/browser/download/download_file.h

Issue 2750713003: Add UMA for estimating disk bandwidth and the time saved with parallel download (Closed)

Patch Set: don't record UMA after pause Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_	5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_

6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_	6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_

7	7

8 #include <stdint.h>	8 #include <stdint.h>

9	9

10 #include <memory>	10 #include <memory>

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 const RenameCompletionCallback& callback) = 0;	69 const RenameCompletionCallback& callback) = 0;

70	70

71 // Detach the file so it is not deleted on destruction.	71 // Detach the file so it is not deleted on destruction.

72 virtual void Detach() = 0;	72 virtual void Detach() = 0;

73	73

74 // Abort the download and automatically close the file.	74 // Abort the download and automatically close the file.

75 virtual void Cancel() = 0;	75 virtual void Cancel() = 0;

76	76

77 virtual const base::FilePath& FullPath() const = 0;	77 virtual const base::FilePath& FullPath() const = 0;

78 virtual bool InProgress() const = 0;	78 virtual bool InProgress() const = 0;

	79 virtual void Pause() {}
	xingliu 2017/03/17 00:02:15 The methods here are all pure virtual, can we also The methods here are all pure virtual, can we also make it pure virtual? It only has two subclasses, so shouldn't be too much work. nit%: Maybe add a comment here, since Pause call is not actually pause the download, but mainly for metric purpose. David Trainor- moved to gerrit 2017/03/17 07:25:40 WasPaused? Show quoted text On 2017/03/17 00:02:15, xingliu wrote: > The methods here are all pure virtual, can we also make it pure virtual? > It only has two subclasses, so shouldn't be too much work. > > nit%: Maybe add a comment here, since Pause call is not actually pause the > download, but mainly for metric purpose. WasPaused? qinmin 2017/03/17 19:52:54 Done. Changed to WasPaused() as suggested by David Show quoted text On 2017/03/17 00:02:15, xingliu wrote: > The methods here are all pure virtual, can we also make it pure virtual? > It only has two subclasses, so shouldn't be too much work. > > nit%: Maybe add a comment here, since Pause call is not actually pause the > download, but mainly for metric purpose. Done. Changed to WasPaused() as suggested by David qinmin 2017/03/17 19:52:54 Done. Show quoted text On 2017/03/17 07:25:40, David Trainor-ping if over 24h wrote: > On 2017/03/17 00:02:15, xingliu wrote: > > The methods here are all pure virtual, can we also make it pure virtual? > > It only has two subclasses, so shouldn't be too much work. > > > > nit%: Maybe add a comment here, since Pause call is not actually pause the > > download, but mainly for metric purpose. > > WasPaused? Done.
79 };	80 };

80	81

81 } // namespace content	82 } // namespace content

82	83

83 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_	84 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_FILE_H_

OLD	NEW

« no previous file with comments | « no previous file | content/browser/download/download_file_impl.h » ('j') | content/browser/download/download_file_impl.cc » ('J')