Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2750623003: Update status for analyze strong mode (Closed)

Created:
3 years, 9 months ago by Johnni Winther
Modified:
3 years, 9 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -32 lines) Patch
M tests/language_strong/language_strong.status View 1 chunk +12 lines, -2 lines 2 comments Download
M tests/lib_strong/lib_strong.status View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 9 months ago (2017-03-14 14:45:28 UTC) #2
Bill Hesse
lgtm https://codereview.chromium.org/2750623003/diff/1/tests/language_strong/language_strong.status File tests/language_strong/language_strong.status (right): https://codereview.chromium.org/2750623003/diff/1/tests/language_strong/language_strong.status#newcode700 tests/language_strong/language_strong.status:700: field3a_negative_test: StaticWarning # Issue 28823 # Issue 29070 ...
3 years, 9 months ago (2017-03-14 14:50:14 UTC) #3
Johnni Winther
Committed patchset #1 (id:1) manually as 4703eb0abf604de40b068941a4d3f84b6a6b37bb (presubmit successful).
3 years, 9 months ago (2017-03-14 14:53:42 UTC) #5
Johnni Winther
3 years, 9 months ago (2017-03-14 15:08:45 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2750623003/diff/1/tests/language_strong/langu...
File tests/language_strong/language_strong.status (right):

https://codereview.chromium.org/2750623003/diff/1/tests/language_strong/langu...
tests/language_strong/language_strong.status:700: field3a_negative_test:
StaticWarning # Issue 28823 # Issue 29070
On 2017/03/14 14:50:14, Bill Hesse wrote:
> Is the first line modified by accident?

Yes! Removed

Powered by Google App Engine
This is Rietveld 408576698