Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2229)

Unified Diff: content/shell/renderer/layout_test/layout_test_content_renderer_client.cc

Issue 2750543003: Support AudioContextOptions latencyHint as double. (Closed)
Patch Set: Fix audiocontextoptions LayoutTest. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
diff --git a/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc b/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
index 163a7415b668fbde8e687b746139672b7daec63f..21009da776497e1bfe051534273e5d2b4cbc0679 100644
--- a/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
+++ b/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
@@ -31,7 +31,9 @@
#include "content/shell/test_runner/web_view_test_proxy.h"
#include "content/test/mock_webclipboard_impl.h"
#include "gin/modules/module_registry.h"
+#include "media/base/audio_latency.h"
#include "media/media_features.h"
+#include "third_party/WebKit/public/platform/WebAudioLatencyHint.h"
#include "third_party/WebKit/public/platform/WebMediaStreamCenter.h"
#include "third_party/WebKit/public/web/WebFrameWidget.h"
#include "third_party/WebKit/public/web/WebKit.h"
@@ -194,10 +196,38 @@ LayoutTestContentRendererClient::OverrideCreateMIDIAccessor(
return interfaces->CreateMIDIAccessor(client);
}
-WebAudioDevice* LayoutTestContentRendererClient::OverrideCreateAudioDevice() {
+WebAudioDevice* LayoutTestContentRendererClient::OverrideCreateAudioDevice(
+ const blink::WebAudioLatencyHint& latency_hint) {
+ const double hw_buffer_size = 128;
+ const double hw_sample_rate = 44100;
+ double buffer_size = 0;
+ switch (latency_hint.category()) {
+ case blink::WebAudioLatencyHint::kCategoryInteractive:
+ buffer_size =
+ media::AudioLatency::GetInteractiveBufferSize(hw_buffer_size);
+ break;
+ case blink::WebAudioLatencyHint::kCategoryBalanced:
+ buffer_size =
+ media::AudioLatency::GetRtcBufferSize(hw_sample_rate, hw_buffer_size);
+ break;
+ case blink::WebAudioLatencyHint::kCategoryPlayback:
+ buffer_size =
+ media::AudioLatency::GetHighLatencyBufferSize(hw_sample_rate, 0);
+ break;
+ case blink::WebAudioLatencyHint::kCategoryExact:
+ buffer_size = media::AudioLatency::GetExactBufferSize(
+ latency_hint.seconds(),
+ media::AudioParameters(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
+ media::CHANNEL_LAYOUT_STEREO, hw_sample_rate,
+ 16, hw_buffer_size));
+ break;
+ default:
+ NOTREACHED();
+ break;
+ }
test_runner::WebTestInterfaces* interfaces =
LayoutTestRenderThreadObserver::GetInstance()->test_interfaces();
- return interfaces->CreateAudioDevice(44100, 128);
+ return interfaces->CreateAudioDevice(hw_sample_rate, buffer_size);
}
WebClipboard* LayoutTestContentRendererClient::OverrideWebClipboard() {

Powered by Google App Engine
This is Rietveld 408576698