Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Unified Diff: content/renderer/media/audio_renderer_mixer_manager.cc

Issue 2750543003: Support AudioContextOptions latencyHint as double. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_renderer_mixer_manager.cc
diff --git a/content/renderer/media/audio_renderer_mixer_manager.cc b/content/renderer/media/audio_renderer_mixer_manager.cc
index f22bdc3f6d7c94d38cff3ee3f6ac4e05466c47ac..5ca7bcfb848641f5fea356ac3470276c5fd6d21b 100644
--- a/content/renderer/media/audio_renderer_mixer_manager.cc
+++ b/content/renderer/media/audio_renderer_mixer_manager.cc
@@ -63,7 +63,13 @@ media::AudioParameters GetMixerOutputParams(
output_sample_rate, preferred_high_latency_output_buffer_size);
break;
case media::AudioLatency::LATENCY_EXACT_MS:
- // TODO(olka): add support when WebAudio requires it.
+ output_buffer_size =
+ std::max(std::min(input_params.frames_per_buffer(),
+ media::AudioLatency::GetHighLatencyBufferSize(
o1ka 2017/03/14 15:55:43 HighLatencyBufferSize is 20 ms. Is it the the maxi
Raymond Toy 2017/03/14 16:14:35 Is 20ms the value for "playback"? In any case, th
+ output_sample_rate,
+ preferred_high_latency_output_buffer_size)),
+ hardware_params.frames_per_buffer());
Raymond Toy 2017/03/14 15:19:39 Blink has a clampTo() function that's easier to re
Andrew MacPherson 2017/03/15 15:08:17 Makes sense, I've refactored the AudioContextTest
+ break;
default:
NOTREACHED();
}

Powered by Google App Engine
This is Rietveld 408576698