third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html - Issue 2750533007: Let insertNewLineInQuotedContent not do anything out of a quote element

Unified Diff: third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html

Issue 2750533007: Let insertNewLineInQuotedContent not do anything out of a quote element (Closed)

Patch Set: update Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« third_party/WebKit/LayoutTests/editing/execCommand/insertNewLineInQuotedContent-outside-quote.html ('K') | « third_party/WebKit/LayoutTests/editing/execCommand/insertNewLineInQuotedContent-outside-quote.html ('k') | third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html b/third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html

index 929fb35687ecb737d1c044ffeb90f8d259af185f..9080651698213ccce7565e88030a1071e036fc6b 100644

--- a/third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html

+++ b/third_party/WebKit/LayoutTests/fast/events/scoped/editing-commands.html

@@ -25,7 +25,7 @@ var commands = [

{name: 'InsertHorizontalRule', value: null},

{name: 'InsertImage', value: '../resources/abe.png'},

{name: 'InsertLineBreak', value: null},

- {name: 'InsertNewlineInQuotedContent', value: null},

+ {name: 'InsertNewlineInQuotedContent', value: null, selector: function (test) { window.getSelection().collapse(document.querySelector('a'), 0); }},

{name: 'InsertOrderedList', value: null},

{name: 'InsertParagraph', value: null},

{name: 'InsertText', value: 'webkit'},

@@ -83,7 +83,7 @@ function isLogConsistent() {

addEventListeners(test);

-var initial = 'hello, <input type="text"><blockquote align="right"><u><a href="about:blank">world</a></u></blockquote>';

+var initial = 'hello, <input type="text"><blockquote type="cite" align="right"><u><a href="about:blank">world</a></u></blockquote>';

yosin_UTC9 2017/03/17 09:27:02 Why do you add |type="cite"|?

yoichio 2017/03/21 03:48:07 Because InsertNewlineInQuotedContent inserts a bre

for (var i = 0; i < commands.length; i++) {

test.innerHTML = initial;

if (i)