Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: headless/public/util/url_fetcher.h

Issue 2750513002: Headless: Pass devtools request id to the URLFetcher (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/util/url_fetcher.h
diff --git a/headless/public/util/url_fetcher.h b/headless/public/util/url_fetcher.h
index ac4bbc51426b29b3f290b3cafdbe1c89652f700b..eede84b4c70b3f0a094ee6af5ecb7a8220d9df70 100644
--- a/headless/public/util/url_fetcher.h
+++ b/headless/public/util/url_fetcher.h
@@ -63,7 +63,13 @@ class URLFetcher {
virtual void StartFetch(const GURL& rewritten_url,
const std::string& method,
const net::HttpRequestHeaders& request_headers,
- ResultListener* result_listener) = 0;
+ const std::string& devtools_request_id_,
Sami 2017/03/13 12:08:24 nit: no trailing underscore
alex clarke (OOO till 29th) 2017/03/13 13:38:22 Done.
+ ResultListener* result_listener);
+ // TODO(alexclarke): Make the above pure virtual and remove this.
+ virtual void StartFetch(const GURL& rewritten_url,
+ const std::string& method,
+ const net::HttpRequestHeaders& request_headers,
+ ResultListener* result_listener);
private:
DISALLOW_COPY_AND_ASSIGN(URLFetcher);

Powered by Google App Engine
This is Rietveld 408576698