Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2750503009: Fix FF test status and re-enable (Closed)

Created:
3 years, 9 months ago by vsm
Modified:
3 years, 9 months ago
Reviewers:
Alan Knight
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix FF test status and re-enable With sra's num parse fixes and couple more, FF should be green again (as well as Chrome Canary). R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/6cf2ac1f62bc164882ca1dce5a14044faf8a4f48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M .travis.yml View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/browser/language_tests.js View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 9 months ago (2017-03-14 15:29:23 UTC) #3
Alan Knight
lgtm
3 years, 9 months ago (2017-03-14 16:26:18 UTC) #4
vsm
3 years, 9 months ago (2017-03-14 16:28:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cf2ac1f62bc164882ca1dce5a14044faf8a4f48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698