[MD Bookmarks] Handle bookmark moves.

chrome/browser/resources/md_bookmarks/reducers.js

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Module of functions which produce a new page state in response
  * to an action. Reducers (in the same sense as Array.prototype.reduce) must be
  * pure functions: they must not modify existing state objects, or make any API
  * calls.
  */
@@ skipping 146 matching lines @@
       return /** @type {BookmarkNode} */ (
           Object.assign({}, node, {children: newChildren}));
     });
   };
 
   /**
    * @param {NodeList} nodes
    * @param {Action} action
    * @return {NodeList}
    */
+  NodeState.moveBookmark = function(nodes, action) {
+    var nodeModifications = {};
+    var id = action.id;
+
+    console.log(action.oldIndex + '=>' + action.index);

[tsergeant, 2017/03/17 02:55:19]

console.log('probably should remove this')

+
+    // Change node's parent.
+    nodeModifications[id] =
+        Object.assign({}, nodes[id], {parentId: action.parentId});
+
+    // Remove from old parent.
+    var oldParentId = action.oldParentId;
+    var oldParentChildren = nodes[oldParentId].children.slice();
+    oldParentChildren.splice(action.oldIndex, 1);
+    nodeModifications[oldParentId] =
+        Object.assign({}, nodes[oldParentId], {children: oldParentChildren});
+
+    // Add to new parent.
+    var parentId = action.parentId;
+    var parentChildren = oldParentId == parentId ?
+        oldParentChildren :
+        nodes[parentId].children.slice();
+    parentChildren.splice(action.index, 0, action.id);
+    nodeModifications[parentId] =
+        Object.assign({}, nodes[parentId], {children: parentChildren});
+
+    return Object.assign({}, nodes, nodeModifications);
+  };
+
+  /**
+   * @param {NodeList} nodes
+   * @param {Action} action
+   * @return {NodeList}
+   */
   NodeState.updateNodes = function(nodes, action) {
     switch (action.name) {
       case 'edit-bookmark':
         return NodeState.editBookmark(nodes, action);
       case 'remove-bookmark':
         return NodeState.removeBookmark(nodes, action);
+      case 'move-bookmark':
+        return NodeState.moveBookmark(nodes, action);
       case 'refresh-nodes':
         return action.nodes;
       default:
         return nodes;
     }
   };
 
   var SelectedFolderState = {};
 
   /**
@@ skipping 42 matching lines @@
         return nodes['0'].children[0];
       default:
         return selectedFolder;
     }
   };
 
   var ClosedFolderState = {};
 
   /**
    * @param {ClosedFolderState} closedFolders
-   * @param {Action} action
+   * @param {string|undefined} id
    * @param {NodeList} nodes
    * @return {ClosedFolderState}
    */
-  ClosedFolderState.openAncestorsOf = function(closedFolders, action, nodes) {
-    var id = action.id;
+  ClosedFolderState.openFolderAndAncestors = function(
+      closedFolders, id, nodes) {
     var modifications = {};
-    var parentId = nodes[id].parentId;
-    while (parentId) {
-      if (closedFolders[parentId]) {
-        modifications[parentId] = false;
+    var currentId = id;
+    while (currentId) {
+      if (closedFolders[currentId]) {
+        modifications[currentId] = false;
       }
-      parentId = nodes[parentId].parentId;
+      currentId = nodes[currentId].parentId;
     }
 
     return Object.assign({}, closedFolders, modifications);
   };
 
   /**
    * @param {ClosedFolderState} closedFolders
    * @param {Action} action
    * @return {ClosedFolderState}
    */
@@ skipping 10 matching lines @@
    * @param {Action} action
    * @param {NodeList} nodes
    * @return {ClosedFolderState}
    */
   ClosedFolderState.updateClosedFolders = function(
       closedFolders, action, nodes) {
     switch (action.name) {
       case 'change-folder-open':
         return ClosedFolderState.changeFolderOpen(closedFolders, action);
       case 'select-folder':
-        return ClosedFolderState.openAncestorsOf(closedFolders, action, nodes);
+        return ClosedFolderState.openFolderAndAncestors(
+            closedFolders, nodes[action.id].parentId, nodes);
+      case 'move-bookmark':
+        if (!nodes[action.id].children)
+          return closedFolders;
+
+        return ClosedFolderState.openFolderAndAncestors(
+            closedFolders, action.parentId, nodes);
       default:
         return closedFolders;
     };
   };
 
   /**
    * Root reducer for the Bookmarks page. This is called by the store in
    * response to an action, and the return value is used to update the UI.
    * @param {!BookmarksPageState} state
    * @param {Action} action
@@ skipping 13 matching lines @@
 
   return {
     reduceAction: reduceAction,
     ClosedFolderState: ClosedFolderState,
     NodeState: NodeState,
     SearchState: SearchState,
     SelectedFolderState: SelectedFolderState,
     SelectionState: SelectionState,
   };
 });