ash/shell/window_watcher_shelf_item_delegate.cc - Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/window_watcher_shelf_item_delegate.cc

Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits. (Closed)

Patch Set: Address comment. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shell/window_watcher_shelf_item_delegate.cc

diff --git a/ash/shell/window_watcher_shelf_item_delegate.cc b/ash/shell/window_watcher_shelf_item_delegate.cc

index b74a61d0fb43e2b184b13f0bc498d236f557956f..2ca46d8b2dd5e8f5053058b28c97ee2e95d946c2 100644

--- a/ash/shell/window_watcher_shelf_item_delegate.cc

+++ b/ash/shell/window_watcher_shelf_item_delegate.cc

@@ -15,7 +15,7 @@ WindowWatcherShelfItemDelegate::WindowWatcherShelfItemDelegate(

ShelfID id,

WindowWatcher* watcher)

: id_(id), watcher_(watcher) {

- DCHECK_GT(id_, 0);

+ DCHECK_NE(id_, kInvalidShelfID);

DCHECK(watcher_);

}

« no previous file with comments | « ash/shell/window_watcher_shelf_item_delegate.h ('k') | ash/test/shelf_view_test_api.h » ('j') | no next file with comments »