Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Unified Diff: ash/public/cpp/shelf_types.h

Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits. (Closed)
Patch Set: Address comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/public/cpp/shelf_struct_traits_unittest.cc ('k') | ash/public/interfaces/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/cpp/shelf_types.h
diff --git a/ash/public/cpp/shelf_types.h b/ash/public/cpp/shelf_types.h
index 5cec6237288886b1e1f26d4f02ce68489d114667..7f24ae401709990316f534b6029e5f3818ab9396 100644
--- a/ash/public/cpp/shelf_types.h
+++ b/ash/public/cpp/shelf_types.h
@@ -89,8 +89,10 @@ enum ShelfAction {
SHELF_ACTION_APP_LIST_SHOWN,
};
-typedef int ShelfID;
-const int kInvalidShelfID = 0;
+// Shelf IDs are sequential values assigned to shelf items by ShelfModel for
+// runtime use; they are not persisted across restarts of the ash environment.
+using ShelfID = uint32_t;
+const ShelfID kInvalidShelfID = 0u;
// The type of a shelf item.
enum ShelfItemType {
« no previous file with comments | « ash/public/cpp/shelf_struct_traits_unittest.cc ('k') | ash/public/interfaces/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698