Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: ash/public/cpp/BUILD.gn

Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits. (Closed)
Patch Set: Address comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/mus/shelf_delegate_mus.h ('k') | ash/public/cpp/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/public/cpp/BUILD.gn
diff --git a/ash/public/cpp/BUILD.gn b/ash/public/cpp/BUILD.gn
index 7b9c8b056581d50595e8241ce1240a6320c2f3d4..8323afc11a409c9d009c48bb7baa3d66f1494ed1 100644
--- a/ash/public/cpp/BUILD.gn
+++ b/ash/public/cpp/BUILD.gn
@@ -9,6 +9,8 @@ component("ash_public_cpp") {
"mus_property_mirror_ash.cc",
"mus_property_mirror_ash.h",
"session_types.h",
+ "shelf_item.cc",
+ "shelf_item.h",
"shelf_types.cc",
"shelf_types.h",
"shell_window_ids.cc",
@@ -22,15 +24,35 @@ component("ash_public_cpp") {
defines = [ "ASH_PUBLIC_IMPLEMENTATION" ]
deps = [
- "//base",
+ "//mojo/common:common_custom_types",
+ "//skia/public/interfaces",
"//ui/aura",
"//ui/views/mus",
]
public_deps = [
"//ash/public/interfaces:interfaces_internal",
+ "//base",
+ "//ui/gfx",
]
allow_circular_includes_from =
[ "//ash/public/interfaces:interfaces_internal" ]
}
+
+source_set("unit_tests") {
+ testonly = true
+ sources = [
+ "shelf_struct_traits_unittest.cc",
+ ]
+
+ deps = [
+ ":ash_public_cpp",
+
+ # TODO(crbug.com/702397): Rely on :ash_public_cpp for this instead.
+ "//ash/public/interfaces:interfaces_internal",
+ "//base",
+ "//testing/gtest",
+ "//ui/gfx:test_support",
+ ]
+}
« no previous file with comments | « ash/mus/shelf_delegate_mus.h ('k') | ash/public/cpp/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698