Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1641)

Unified Diff: ash/common/shelf/app_list_shelf_item_delegate.cc

Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits. (Closed)
Patch Set: Address comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/BUILD.gn ('k') | ash/common/shelf/shelf_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/shelf/app_list_shelf_item_delegate.cc
diff --git a/ash/common/shelf/app_list_shelf_item_delegate.cc b/ash/common/shelf/app_list_shelf_item_delegate.cc
index 42bf94d7f0f489b616705dc62d64e1ba31c42e1f..c3da04402799a8d487dc1a8e8f9740e7779ea19d 100644
--- a/ash/common/shelf/app_list_shelf_item_delegate.cc
+++ b/ash/common/shelf/app_list_shelf_item_delegate.cc
@@ -24,7 +24,7 @@ void AppListShelfItemDelegate::CreateAppListItemAndDelegate(ShelfModel* model) {
// Create an AppListShelfItemDelegate for that item.
ShelfID id = model->items()[index].id;
- DCHECK_GE(id, 0);
+ DCHECK_NE(id, kInvalidShelfID);
model->SetShelfItemDelegate(id, base::MakeUnique<AppListShelfItemDelegate>());
}
« no previous file with comments | « ash/BUILD.gn ('k') | ash/common/shelf/shelf_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698