ash/common/shelf/shelf_controller.cc - Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/shelf/shelf_controller.cc

Issue 2750463009: mash: Fix ShelfItem mojo struct; add enums and traits. (Closed)

Patch Set: Address comments; try adding a unit test. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/common/shelf/shelf_controller.cc

diff --git a/ash/common/shelf/shelf_controller.cc b/ash/common/shelf/shelf_controller.cc

index fa475934c2faad3351559f20758d98f2c2d8a1fb..8466fc84239bb5a38b236b617a46d8e0d0f36ee9 100644

--- a/ash/common/shelf/shelf_controller.cc

+++ b/ash/common/shelf/shelf_controller.cc

@@ -112,7 +112,7 @@ void ShelfController::SetAutoHideBehavior(ShelfAutoHideBehavior auto_hide,

}

void ShelfController::PinItem(

- mojom::ShelfItemPtr item,

+ const ShelfItem& item,

mojom::ShelfItemDelegateAssociatedPtrInfo delegate) {

NOTIMPLEMENTED();

}