Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 # Copyright 2014 Google Inc. All Rights Reserved. | 1 # Copyright 2014 Google Inc. All Rights Reserved. |
| 2 # | 2 # |
| 3 # Licensed under the Apache License, Version 2.0 (the "License"); | 3 # Licensed under the Apache License, Version 2.0 (the "License"); |
| 4 # you may not use this file except in compliance with the License. | 4 # you may not use this file except in compliance with the License. |
| 5 # You may obtain a copy of the License at | 5 # You may obtain a copy of the License at |
| 6 # | 6 # |
| 7 # http://www.apache.org/licenses/LICENSE-2.0 | 7 # http://www.apache.org/licenses/LICENSE-2.0 |
| 8 # | 8 # |
| 9 # Unless required by applicable law or agreed to in writing, software | 9 # Unless required by applicable law or agreed to in writing, software |
| 10 # distributed under the License is distributed on an "AS IS" BASIS, | 10 # distributed under the License is distributed on an "AS IS" BASIS, |
| 11 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | 11 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. |
| 12 # See the License for the specific language governing permissions and | 12 # See the License for the specific language governing permissions and |
| 13 # limitations under the License. | 13 # limitations under the License. |
| 14 | 14 |
| 15 vars = { | 15 vars = { |
| 16 # Name of the directory to which the repository is pulled in. | 16 # Name of the directory to which the repository is pulled in. |
| 17 "root": "src", | 17 "root": "src", |
| 18 # This is expected to be Python 2.7 from depot_tools. | 18 # This is expected to be Python 2.7 from depot_tools. |
| 19 "python_path": "python", | 19 "python_path": "python", |
| 20 | 20 |
| 21 "chromium_git": "https://chromium.googlesource.com", | 21 "chromium_git": "https://chromium.googlesource.com", |
|
csharp
2017/03/15 17:22:34
nit: Please add a blank line after this
ftirelo
2017/03/21 16:54:28
Done.
| |
| 22 "buildtools_revision": "a7cc7a3e21a061975b33dcdcd81a9716ba614c3c", | 22 "buildtools_revision": "a7cc7a3e21a061975b33dcdcd81a9716ba614c3c", |
| 23 "icu_revision": "9cd2828740572ba6f694b9365236a8356fd06147", | 23 "icu_revision": "9cd2828740572ba6f694b9365236a8356fd06147", |
| 24 # Three lines of non-changing comments so that | |
|
csharp
2017/03/15 17:22:34
I don't think we need these 3 lines since I don't
ftirelo
2017/03/21 16:54:28
Done.
| |
| 25 # the commit queue can handle CLs rolling catapult | |
| 26 # and whatever else without interference from each other. | |
| 27 "catapult_revision": "e9f547be045d4e50cb2d4927261d500e425c364c", | |
|
csharp
2017/03/15 17:22:34
nit: Move to after buildtools_revision
ftirelo
2017/03/21 16:54:28
Done.
| |
| 24 } | 28 } |
| 25 | 29 |
| 26 deps = { | 30 deps = { |
| 27 Var("root") + "/buildtools": | 31 Var("root") + "/buildtools": |
| 28 (Var('chromium_git') + '/chromium/buildtools.git' + '@' + | 32 (Var('chromium_git') + '/chromium/buildtools.git' + '@' + |
| 29 Var('buildtools_revision')), | 33 Var('buildtools_revision')), |
| 30 Var("root") + "/third_party/icu": | 34 Var("root") + "/third_party/icu": |
| 31 Var('chromium_git') + '/chromium/deps/icu.git' + '@' + Var('icu_revision'), | 35 Var('chromium_git') + '/chromium/deps/icu.git' + '@' + Var('icu_revision'), |
| 36 Var("root") + "/third_party/catapult": | |
|
grt (UTC plus 2)
2017/03/16 09:02:10
nit: please sort these a la csharp's comment above
ftirelo
2017/03/21 16:54:28
Done.
| |
| 37 Var('chromium_git') + | |
| 38 '/external/github.com/catapult-project/catapult.git' + '@' + | |
| 39 Var('catapult_revision'), | |
| 32 } | 40 } |
| 33 | 41 |
| 34 include_rules = [ | 42 include_rules = [ |
| 35 ] | 43 ] |
| 36 | 44 |
| 37 hooks = [ | 45 hooks = [ |
| 38 { | 46 { |
| 39 "name": "run_gitdeps", | 47 "name": "run_gitdeps", |
| 40 "pattern": ".", | 48 "pattern": ".", |
| 41 "action": [Var("python_path"), | 49 "action": [Var("python_path"), |
| (...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 77 "pattern": ".", | 85 "pattern": ".", |
| 78 "action": ["download_from_google_storage", | 86 "action": ["download_from_google_storage", |
| 79 "--no_resume", | 87 "--no_resume", |
| 80 "--platform=win32", | 88 "--platform=win32", |
| 81 "--no_auth", | 89 "--no_auth", |
| 82 "--bucket", "chromium-clang-format", | 90 "--bucket", "chromium-clang-format", |
| 83 "-s", Var("root") + "/buildtools/win/clang-format.exe.sha1", | 91 "-s", Var("root") + "/buildtools/win/clang-format.exe.sha1", |
| 84 ], | 92 ], |
| 85 }, | 93 }, |
| 86 ] | 94 ] |
| OLD | NEW |