OLD | NEW |
---|---|
(Empty) | |
1 // Copyright 2017 The Chromium Authors. All Rights Reserved. | |
grt (UTC plus 2)
2017/03/15 10:58:13
why not the full license header?
ftirelo
2017/03/15 14:27:58
No reason. Copied the header from the internal rep
grt (UTC plus 2)
2017/03/16 09:02:10
Just to confirm: this new repo you're creating sho
ftirelo
2017/03/21 16:54:28
Yes. Same license as Chromium. Our original goal w
| |
2 | |
3 module pipa.mojom; | |
4 | |
5 enum ObservedBehavior { | |
6 UNSPECIFIED = 0, | |
7 ADS_INJECTOR = 1, | |
8 SETTINGS_HIJACKER= 2, | |
grt (UTC plus 2)
2017/03/15 10:58:13
nit: missing whitespace before '='
ftirelo
2017/03/15 14:27:58
I think I'm relying too much on git cl format :)
| |
9 BROWSER_HIJACKER = 3, | |
10 }; | |
11 | |
12 // Information about removable Unwanted Software matched by the Software | |
13 // Reporter to be shown in the Chrome prompt. | |
14 struct UwS { | |
15 string name; | |
grt (UTC plus 2)
2017/03/15 10:58:13
nit: document this field
ftirelo
2017/03/15 14:27:58
Done.
| |
16 // List of behaviors to be presented to the user. | |
grt (UTC plus 2)
2017/03/15 10:58:13
nit: in c++ style, we have a blank line separating
ftirelo
2017/03/15 14:27:58
A quick search didn't show any style-guide for Moj
| |
17 array<ObservedBehavior> observed_behaviours; | |
18 // List of files that will be deleted by the Chrome Cleanup Tool for this | |
grt (UTC plus 2)
2017/03/15 10:58:13
can you be more specific? is it a list of fully-qu
ftirelo
2017/03/15 14:27:58
Done.
| |
19 // unwanted software. | |
20 array<string> files_to_delete; | |
21 }; | |
22 | |
23 // A request sent by the Software Reporter Tool to Chrome requiring the user | |
24 // to be prompted. | |
25 struct PromptUserRequest { | |
26 array<UwS> removable_uws_found; | |
27 // If true, the Chrome Cleanup Tool will need to run elevated. | |
28 bool elevation_required; | |
29 }; | |
30 | |
31 // The request sent by Chrome to the Software Reporter Tool with the user | |
grt (UTC plus 2)
2017/03/15 10:58:13
request -> response?
ftirelo
2017/03/15 14:27:58
Done.
| |
32 // acceptance result. | |
33 struct PromptUserResponse { | |
34 // If true, the user accepted the prompt. | |
35 bool prompt_accepted; | |
36 // If true, the user agrees with sending detailed logs information to Google. | |
37 bool logs_uploading_enabled; | |
38 }; | |
39 | |
40 // Service invoked by the Software Reporter Tool to request Chrome to prompt | |
grt (UTC plus 2)
2017/03/15 10:58:13
nit: document the service from the other side, sin
ftirelo
2017/03/15 14:27:58
Done.
| |
41 // user. | |
42 interface ChromePrompt { | |
43 PromptUser(PromptUserRequest request) => (PromptUserResponse response); | |
Ken Rockot(use gerrit already)
2017/03/14 18:13:06
nit: If these Request and Response types are only
ftirelo
2017/03/14 20:26:58
The main reason is that we expect this to grow wit
| |
44 }; | |
OLD | NEW |