Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4830)

Unified Diff: chrome/common/extensions/api/dial.idl

Issue 2750453002: Add DiscoveryNetworkMonitor implementation (Closed)
Patch Set: Respond to mfoltz' comments, add chrome.dial API back with tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/dial.idl
diff --git a/chrome/common/extensions/api/dial.idl b/chrome/common/extensions/api/dial.idl
index 3df796f1d843adcf65a74113df3b60ca9d1bc794..e4edbf9e23a93a68ee2063de85d7fa8477373d3c 100644
--- a/chrome/common/extensions/api/dial.idl
+++ b/chrome/common/extensions/api/dial.idl
@@ -38,7 +38,9 @@ namespace dial {
enum DialErrorCode {
no_listeners,
+ // Deprecated. Use onNetworkIdChanged instead.
no_valid_network_interfaces,
+ // Deprecated. Use onNetworkIdChanged instead.
network_disconnected,
cellular_network,
socket_error,
@@ -51,6 +53,7 @@ namespace dial {
callback BooleanCallback = void (boolean result);
callback DeviceDescriptionCallback = void (DialDeviceDescription result);
+ callback NetworkIdCallback = void (DOMString result);
interface Functions {
@@ -70,6 +73,10 @@ namespace dial {
// code.
static void fetchDeviceDescription(DOMString deviceLabel,
DeviceDescriptionCallback callback);
+
+ // Returns the current discovery network identifier. See the documentation
+ // for onNetworkIdChanged for details.
+ static void getNetworkId(NetworkIdCallback callback);
};
interface Events {
@@ -87,5 +94,21 @@ namespace dial {
// Event fired to inform clients on errors during device discovery.
static void onError(DialError error);
+
+ // Fired when the network being used for discovery has changed. |networkId|
+ // contains a short signature combining information from network interface
+ // and WiFi network identifiers to identify the current set of networks
+ // being used for discovery. This can be used by clients to clear and
+ // re-bootstrap device caches on a network change.
+ //
+ // |networkId| can take the following values:
+ // - "hex-string" is a hash-style signature of the set of active networks.
+ // - "disconnected" means there is no active network for discovery.
+ // - "unknown" means there is an active network, but its signature
+ // cannot be determined.
+ //
+ // This event may be throttled to prevent it from firing too frequently; it
+ // is designed to be event-page friendly.
+ static void onNetworkIdChanged(DOMString networkId);
};
};

Powered by Google App Engine
This is Rietveld 408576698