Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc

Issue 2750453002: Add DiscoveryNetworkMonitor implementation (Closed)
Patch Set: Temporarily fix Windows and Mac compilation Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc
diff --git a/chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc b/chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e4564e54abaef6c371a5812ccf96e3b099a04f05
--- /dev/null
+++ b/chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc
@@ -0,0 +1,153 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/media/router/discovery/discovery_network_monitor.h"
+
+#include <memory>
+
+#include "base/run_loop.h"
+#include "content/public/browser/browser_thread.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace {
+
+using content::BrowserThread;
+
+using testing::_;
+using testing::Invoke;
+
+class MockDiscoveryObserver : public DiscoveryNetworkMonitor::Observer {
+ public:
+ MOCK_METHOD1(OnNetworksChanged, void(const DiscoveryNetworkMonitor&));
+};
+
+} // namespace
+
+class DiscoveryNetworkMonitorTest : public testing::Test {
+ protected:
+ void SetUp() override {
+ fake_network_info.clear();
+ discovery_network_monitor->SetNetworkInfoFunctionForTest(
+ &FakeGetNetworkInfo);
+ }
+
+ void TearDown() override { delete discovery_network_monitor; }
+
+ static std::vector<DiscoveryNetworkInfo> FakeGetNetworkInfo() {
+ return fake_network_info;
+ }
+
+ content::TestBrowserThreadBundle test_browser_thread_bundle;
+ MockDiscoveryObserver mock_observer;
+
+ std::vector<DiscoveryNetworkInfo> fake_ethernet_info{
+ {{std::string("enp0s2"), std::string("ethernet1")}}};
+ std::vector<DiscoveryNetworkInfo> fake_wifi_info{
+ {DiscoveryNetworkInfo{std::string("wlp3s0"), std::string("wifi1")},
+ DiscoveryNetworkInfo{std::string("wlp3s1"), std::string("wifi2")}}};
+
+ std::unique_ptr<net::NetworkChangeNotifier> network_change_notifier =
+ base::WrapUnique(net::NetworkChangeNotifier::CreateMock());
+
+ static std::vector<DiscoveryNetworkInfo> fake_network_info;
+ // A raw pointer is used here with the delete in TearDown to avoid making the
+ // destructor public.
+ DiscoveryNetworkMonitor* discovery_network_monitor =
+ new DiscoveryNetworkMonitor();
+};
+
+// static
+std::vector<DiscoveryNetworkInfo>
+ DiscoveryNetworkMonitorTest::fake_network_info;
+
+TEST_F(DiscoveryNetworkMonitorTest, NetworkIdIsConsistent) {
+ fake_network_info = fake_ethernet_info;
+ std::string current_network_id;
+
+ auto capture_network_id =
+ [&current_network_id](const DiscoveryNetworkMonitor& monitor) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ current_network_id = monitor.GetNetworkId();
+ };
+ discovery_network_monitor->AddObserver(&mock_observer);
+ EXPECT_CALL(mock_observer, OnNetworksChanged(_))
+ .WillOnce(Invoke(capture_network_id));
+
+ net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
+ net::NetworkChangeNotifier::CONNECTION_ETHERNET);
+ base::RunLoop().RunUntilIdle();
+
+ std::string ethernet_network_id = current_network_id;
+
+ fake_network_info.clear();
+ EXPECT_CALL(mock_observer, OnNetworksChanged(_))
+ .WillOnce(Invoke(capture_network_id));
+
+ net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
+ net::NetworkChangeNotifier::CONNECTION_NONE);
+ base::RunLoop().RunUntilIdle();
+
+ fake_network_info = fake_wifi_info;
+ EXPECT_CALL(mock_observer, OnNetworksChanged(_))
+ .WillOnce(Invoke(capture_network_id));
+
+ net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
+ net::NetworkChangeNotifier::CONNECTION_WIFI);
+ base::RunLoop().RunUntilIdle();
+
+ std::string wifi_network_id = current_network_id;
+ fake_network_info = fake_ethernet_info;
+ EXPECT_CALL(mock_observer, OnNetworksChanged(_))
+ .WillOnce(Invoke(capture_network_id));
+
+ net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
+ net::NetworkChangeNotifier::CONNECTION_ETHERNET);
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(ethernet_network_id, current_network_id);
+ EXPECT_NE(ethernet_network_id, wifi_network_id);
+
+ discovery_network_monitor->RemoveObserver(&mock_observer);
+}
+
+TEST_F(DiscoveryNetworkMonitorTest, RemoveObserverStopsNotifications) {
+ fake_network_info = fake_ethernet_info;
+
+ discovery_network_monitor->AddObserver(&mock_observer);
+ EXPECT_CALL(mock_observer, OnNetworksChanged(_))
+ .WillOnce(Invoke([](const DiscoveryNetworkMonitor& monitor) {
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
+ }));
+
+ net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
+ net::NetworkChangeNotifier::CONNECTION_ETHERNET);
+ base::RunLoop().RunUntilIdle();
+
+ discovery_network_monitor->RemoveObserver(&mock_observer);
+ fake_network_info.clear();
+
+ net::NetworkChangeNotifier::NotifyObserversOfNetworkChangeForTests(
+ net::NetworkChangeNotifier::CONNECTION_NONE);
+ base::RunLoop().RunUntilIdle();
+}
+
+TEST_F(DiscoveryNetworkMonitorTest, RefreshIndependentOfChangeObserver) {
+ fake_network_info = fake_ethernet_info;
+
+ discovery_network_monitor->AddObserver(&mock_observer);
+ auto force_refresh_callback = [](const DiscoveryNetworkMonitor* monitor) {
+ EXPECT_NE(std::string(DiscoveryNetworkMonitor::kNetworkIdDisconnected),
+ monitor->GetNetworkId());
+ EXPECT_NE(std::string(DiscoveryNetworkMonitor::kNetworkIdUnknown),
+ monitor->GetNetworkId());
+ };
+
+ EXPECT_EQ(std::string(DiscoveryNetworkMonitor::kNetworkIdDisconnected),
+ discovery_network_monitor->GetNetworkId());
+ discovery_network_monitor->Refresh(base::Bind(
+ force_refresh_callback, base::Unretained(discovery_network_monitor)));
+ base::RunLoop().RunUntilIdle();
+}

Powered by Google App Engine
This is Rietveld 408576698