chrome/browser/media/router/discovery/discovery_network_list.h - Issue 2750453002: Add DiscoveryNetworkMonitor implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/router/discovery/discovery_network_list.h

Issue 2750453002: Add DiscoveryNetworkMonitor implementation (Closed)

Patch Set: Respond to mfoltz' comments, add chrome.dial API back with tests Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/api/dial/dial_api.cc ('K') | « chrome/browser/media/router/BUILD.gn ('k') | chrome/browser/media/router/discovery/discovery_network_list_posix.cc » ('j') | chrome/browser/media/router/discovery/discovery_network_list_posix.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DISCOVERY_NETWORK_LIST_H_

	6 #define CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DISCOVERY_NETWORK_LIST_H_

	7

	8 #include <string>

	9 #include <vector>

	10

	11 struct DiscoveryNetworkId {

	12 // e.g. eth0, wlan0

	13 std::string interface_name;

	14 // Some form of identifier for the network to which this interface is

	15 // connected. For ethernet, this will simply be the ethernet adapter's MAC
	mark a. foltz 2017/04/26 22:25:11 The SSID identifies a network, while the MAC addre The SSID identifies a network, while the MAC address identifies a device. You might clarify the two cases: "For WiFi, we assume that the SSID identifies the connected network. For Ethernet, we assume the network remains the same for a given device, so we use its MAC address." btolsch 2017/05/03 22:03:09 Done. Show quoted text On 2017/04/26 22:25:11, mark a. foltz wrote: > The SSID identifies a network, while the MAC address identifies a device. You > might clarify the two cases: > > "For WiFi, we assume that the SSID identifies the connected network. For > Ethernet, we assume the network remains the same for a given device, so we use > its MAC address." Done.
	16 // address, for Wifi it will be the associated SSID.

	17 std::string network_id;

	18 };

	19

	20 std::vector<DiscoveryNetworkId> GetDiscoveryNetworkIdList();

	21

	22 #endif // CHROME_BROWSER_MEDIA_ROUTER_DISCOVERY_DISCOVERY_NETWORK_LIST_H_

OLD	NEW